Misleading deprecation warning for POSTGRES env variables

["Borkowski, Dominik" <do...@vt.edu>]

Hello,

In one of our testbed environments we use guacamole with PostgreSQL authentication backend, on arm64 containers. Since we can’t cleanly build 1.5.5 anymore, due to alpine changes, I attempted to get the current/1.6.0 release going.

Using everything we had previously set up for postgres, new guacamole kept failing to connect to postgres, despite psql client working just fine. After debugging which took me entirely too long, I finally noticed the following messages:

WARNING: The "POSTGRESQL_USERNAME" environment variable has been deprecated in favor of "POSTGRESQL_USERNAME". Please migrate your configuration when possible, as support for the older name may be removed in future releases.
WARNING: The "POSTGRESQL_" prefix for environment variables has been deprecated in favor of the "POSTGRESQL_" prefix. Please migrate your configuration when possible, as support for the older prefix may be removed in future releases.

Adjusting the variables fixed the authentication. Unfortunately, there are couple issues with these warnings:

1) ‘may be removed’ is clearly not true, as the older style variables no longer work
2) first warning should read 'The “POSTGRES_USER” environment variable has been deprecated in favor of "POSTGRESQL_USERNAME”.’

Hope this helps other folks who run into similar issues.

Cheers!
—
dom
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@guacamole.apache.org
For additional commands, e-mail: user-help@guacamole.apache.org

Re: Misleading deprecation warning for POSTGRES env variables

[Michael Jumper <mj...@apache.org>]

On 12/2/24 6:05 AM, Borkowski, Dominik wrote:
> Hello,
> 
> In one of our testbed environments we use guacamole with PostgreSQL authentication backend, on arm64 containers. Since we can’t cleanly build 1.5.5 anymore, due to alpine changes, I attempted to get the current/1.6.0 release going.
> 
> Using everything we had previously set up for postgres, new guacamole kept failing to connect to postgres, despite psql client working just fine. After debugging which took me entirely too long, I finally noticed the following messages:
> 
> WARNING: The "POSTGRESQL_USERNAME" environment variable has been deprecated in favor of "POSTGRESQL_USERNAME". Please migrate your configuration when possible, as support for the older name may be removed in future releases.
> WARNING: The "POSTGRESQL_" prefix for environment variables has been deprecated in favor of the "POSTGRESQL_" prefix. Please migrate your configuration when possible, as support for the older prefix may be removed in future releases.
> 
> Adjusting the variables fixed the authentication. Unfortunately, there are couple issues with these warnings:
> 
> 1) ‘may be removed’ is clearly not true, as the older style variables no longer work
> 2) first warning should read 'The “POSTGRES_USER” environment variable has been deprecated in favor of "POSTGRESQL_USERNAME”.’
> 
> Hope this helps other folks who run into similar issues.
> 

Can you confirm the commit hash that you built from when building the 
Docker image for guacamole-client?

When I try this myself, I see correct warnings, and the values from the 
old variables are correctly copied over to the new variables:

WARNING: The "POSTGRES_USER" environment variable has been deprecated in 
favor of "POSTGRESQL_USERNAME". Please migrate your configuration when 
possible, as support for the older name may be removed in future releases.
WARNING: The "POSTGRES_" prefix for environment variables has been 
deprecated in favor of the "POSTGRESQL_" prefix. Please migrate your 
configuration when possible, as support for the older prefix may be 
removed in future releases.

This is all handled by:

https://github.com/apache/guacamole-client/blob/333b73c3ddbb5756803a385b599988606ed06aca/guacamole-docker/entrypoint.d/010-migrate-legacy-variables.sh

- Mike


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@guacamole.apache.org
For additional commands, e-mail: user-help@guacamole.apache.org