You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/08/18 00:01:28 UTC
[GitHub] [phoenix] kadirozde commented on a change in pull request #860: PHOENIX-6080: Add a check to Index Rebuild jobs to check region closi…
kadirozde commented on a change in pull request #860:
URL: https://github.com/apache/phoenix/pull/860#discussion_r471838380
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -1301,11 +1301,24 @@ public boolean next(List<Cell> results) throws IOException {
try {
localScanner = getLocalScanner();
if (localScanner == null) {
+ region.closeRegionOperation();
return false;
}
synchronized (localScanner) {
if (!shouldVerify()) {
skipped = true;
+ region.closeRegionOperation();
Review comment:
As I stated before, the fix is to check the isRegionClosingOrSplitting attribute of the UngroupedAggregateRegionObserver coproc and return an IOException after every scanner next or table batch operation done during index rebuild or verification if the region is closing or splitting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org