[GitHub] [shardingsphere] yx9o commented on a change in pull request #15802: Add `IF EXISTS` keyword to `DROP DB_DISCOVERY TYPE`.

[GitBox <gi...@apache.org>]

yx9o commented on a change in pull request #15802:
URL: https://github.com/apache/shardingsphere/pull/15802#discussion_r820368338



##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/rdl/drop.xml
##########
@@ -28,7 +28,8 @@
     <distsql-case id="drop-readwrite-splitting-rule" value="DROP READWRITE_SPLITTING RULE ms_group_0,ms_group_1" />
     <distsql-case id="drop-database-discovery-rule" value="DROP DB_DISCOVERY RULE ha_group_0,ha_group_1" />
     <distsql-case id="drop-database-discovery-rule-if-exists" value="DROP DB_DISCOVERY RULE IF EXISTS ha_group_0,ha_group_1" />
-    <distsql-case id="drop-database-discovery-type" value="DROP DB_DISCOVERY TYPE type_name_0,type_name_1" />
+    <distsql-case id="drop-database-discovery-type" value="DROP DB_DISCOVERY TYPE IF EXISTS type_name_0,type_name_1" />
+    <distsql-case id="drop-database-discovery-type-if-exists" value="DROP DB_DISCOVERY TYPE type_name_0,type_name_1" />
     <distsql-case id="drop-database-discovery-heartbeat" value="DROP DB_DISCOVERY HEARTBEAT heartbeat_name_0,heartbeat_name_1" />

Review comment:
       > In `drop-database-discovery-type-if-exists`, there is no IF EXISTS keyword?
   
   Done, please review, thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org