You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/25 10:28:48 UTC
[GitHub] srowen commented on a change in pull request #23884:
[MINOR]Simplify boolean expression
srowen commented on a change in pull request #23884: [MINOR]Simplify boolean expression
URL: https://github.com/apache/spark/pull/23884#discussion_r259760453
##########
File path: core/src/test/scala/org/apache/spark/util/BoundedPriorityQueueSuite.scala
##########
@@ -29,12 +29,12 @@ class BoundedPriorityQueueSuite extends SparkFunSuite {
pq += 0.3
pq += 0.01
- assert(pq.isEmpty == false)
+ assert(!pq.isEmpty)
Review comment:
How about `.nonEmpty` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org