You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/18 05:12:09 UTC

[GitHub] [yunikorn-core] ycr-oss commented on a diff in pull request #430: [YUNIKORN-1282] Resource metrics are not tracked correctly for all queue types

ycr-oss commented on code in PR #430:
URL: https://github.com/apache/yunikorn-core/pull/430#discussion_r948655450


##########
pkg/scheduler/objects/queue.go:
##########
@@ -1017,6 +1019,8 @@ func (sq *Queue) SetMaxResource(max *resources.Resource) {
 		zap.String("current max", sq.maxResource.String()),
 		zap.String("new max", max.String()))
 	sq.maxResource = max.Clone()
+	sq.updateGuaranteedResourceMetrics()

Review Comment:
   Good catch. Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org