[jira] [Commented] (CASSANDRA-18725) IsolatedJMX should not release all TCPEndpoints on instance shutdown

["Doug Rohrer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753244#comment-17753244 ] 

Doug Rohrer commented on CASSANDRA-18725:
-----------------------------------------

These PRs are waiting on the in-jvm dtest framework 0.0.16 snapshot release ([https://github.com/apache/cassandra-in-jvm-dtest-api/pull/37]) which [~djoshi] is working on or will be in the next day or so. Once that's done, we'll start the vote for the dtest-api release and these PRs can run on the snapshot in CircleCI.

Before merging, we need to get the official 0.0.16 release done and change the references to 0.0.16-SNAPSHOT in all of the ant files, and then make sure not to commit the use of the SNAPSHOT repository.

> IsolatedJMX should not release all TCPEndpoints on instance shutdown
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-18725
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18725
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Doug Rohrer
>            Priority: Normal
>             Fix For: 4.0, 4.1.x, 5.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> In the original implementation of the JMX feature, we fixed some memory leaks by clearing some internal state in Java’s TCPEndpoint. However, that implementation was overly aggressive and cleared the whole map, vs. just removing the endpoints created by the individual instances. This causes issues when you remove a node from the cluster (as all of the endpoints are cleared, not just the ones in use by that instance).
>  
> In stead, we should check if the endpoint was created by the instance in question and only remove it if it was.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org