You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/12/13 23:44:46 UTC
[GitHub] [cxf] reta opened a new pull request #884: Update Netty to 4.1.72.Final
reta opened a new pull request #884:
URL: https://github.com/apache/cxf/pull/884
Update Netty to 4.1.72.Final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] ffang commented on a change in pull request #884: Update Netty to 4.1.72.Final
Posted by GitBox <gi...@apache.org>.
ffang commented on a change in pull request #884:
URL: https://github.com/apache/cxf/pull/884#discussion_r769054417
##########
File path: osgi/karaf/features/src/main/resources/features.xml
##########
@@ -192,6 +192,7 @@
<feature name="cxf-http-netty-client" version="${project.version}">
<feature version="${project.version}">cxf-http</feature>
<bundle dependency="true" start-level="40">mvn:${cxf.servlet-api.group}/${cxf.servlet-api.artifact}/${cxf.servlet-api.version}</bundle>
+ <bundle start-level="40">mvn:io.netty/netty-tcnative-classes/${cxf.netty.tcnative.version}</bundle>
Review comment:
LGTM,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta merged pull request #884: Update Netty to 4.1.72.Final
Posted by GitBox <gi...@apache.org>.
reta merged pull request #884:
URL: https://github.com/apache/cxf/pull/884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a change in pull request #884: Update Netty to 4.1.72.Final
Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #884:
URL: https://github.com/apache/cxf/pull/884#discussion_r768209154
##########
File path: osgi/karaf/features/src/main/resources/features.xml
##########
@@ -192,6 +192,7 @@
<feature name="cxf-http-netty-client" version="${project.version}">
<feature version="${project.version}">cxf-http</feature>
<bundle dependency="true" start-level="40">mvn:${cxf.servlet-api.group}/${cxf.servlet-api.artifact}/${cxf.servlet-api.version}</bundle>
+ <bundle start-level="40">mvn:io.netty/netty-tcnative-classes/${cxf.netty.tcnative.version}</bundle>
Review comment:
See please https://github.com/netty/netty/pull/11745, new dependency has been introduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #884: Update Netty to 4.1.72.Final
Posted by GitBox <gi...@apache.org>.
reta commented on pull request #884:
URL: https://github.com/apache/cxf/pull/884#issuecomment-993015267
@ffang would you mind please taking a look, the change is trivial but new dependency has been introduced by Netty (https://github.com/netty/netty/pull/11745) and led to OSGi features update, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org