You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 16:12:01 UTC

[GitHub] [airflow] potiuk commented on pull request #12786: Get airflow version from importlib.metadata rather than hard-coding

potiuk commented on pull request #12786:
URL: https://github.com/apache/airflow/pull/12786#issuecomment-738109274


   We should fix it in few other places:* 
   
   * scripts/ci/provider_packages/ci_install_and_test_provider_packages.sh -> it can be removed, it was needed because setup.py imported it before
   * Dockerfile.ci -> ditto
   * STATIC_CODE_CHECKS.rst has reference to removed pre-commit rule
   * dev/README.md needs to be updated
   * dev/README_RELEASE_AIRLFOW.md as well
   * dev/provider_packages/enter_breeze_provider_package_tests.sh also can be removed as it was needed only for setup.py
   * scripts/ci/libraries/_initialization.sh - it reads version from airflow/version.py, it should from setup.py, also it uses airfflow/version.py in calculation of md5sum of files for which changes trigger the build (includes comment about the mechanism)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org