You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Martin Wehner (JIRA)" <ji...@apache.org> on 2012/10/12 14:15:03 UTC

[jira] [Created] (SLING-2619) ReferrerFilter declares no scope

Martin Wehner created SLING-2619:
------------------------------------

             Summary: ReferrerFilter declares no scope
                 Key: SLING-2619
                 URL: https://issues.apache.org/jira/browse/SLING-2619
             Project: Sling
          Issue Type: Bug
          Components: Extensions
    Affects Versions: Security 1.0.0
            Reporter: Martin Wehner


The ReferrerFilter currently doesn't define a sling.filter.scope property in its service registration, so it isn't part of any Sling filter chain and thereby effectively deactivated by default. The scope property (request) was removed in a refactoring in Revision 1155355 ("Use global filter instead of Sling filter"), perhaps by mistake.
If it was done on purpose, how is the filter supposed to be invoked now?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (SLING-2619) ReferrerFilter declares no scope

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned SLING-2619:
----------------------------------------

    Assignee: Carsten Ziegeler

This refactoring introduced a property to register the filter with the new Http Service Whiteboard support of Apache Felix. This allows registering Http Service level filters as services provided the Http Service implements the Apache Felix ExtHttpService.

Maybe Carsten can point to an issue related to this change (or create one after the fact ;-) ).
                
> ReferrerFilter declares no scope
> --------------------------------
>
>                 Key: SLING-2619
>                 URL: https://issues.apache.org/jira/browse/SLING-2619
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Security 1.0.0
>            Reporter: Martin Wehner
>            Assignee: Carsten Ziegeler
>
> The ReferrerFilter currently doesn't define a sling.filter.scope property in its service registration, so it isn't part of any Sling filter chain and thereby effectively deactivated by default. The scope property (request) was removed in a refactoring in Revision 1155355 ("Use global filter instead of Sling filter"), perhaps by mistake.
> If it was done on purpose, how is the filter supposed to be invoked now?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2619) ReferrerFilter declares no scope

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-2619.
-------------------------------------

    Resolution: Won't Fix

As pointed out by Felix, we changed the filter to be effective for all requests not just requests going through the Sling Main Servlet.
I'Ve created SLING-2664 in retrospective
                
> ReferrerFilter declares no scope
> --------------------------------
>
>                 Key: SLING-2619
>                 URL: https://issues.apache.org/jira/browse/SLING-2619
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Security 1.0.0
>            Reporter: Martin Wehner
>            Assignee: Carsten Ziegeler
>
> The ReferrerFilter currently doesn't define a sling.filter.scope property in its service registration, so it isn't part of any Sling filter chain and thereby effectively deactivated by default. The scope property (request) was removed in a refactoring in Revision 1155355 ("Use global filter instead of Sling filter"), perhaps by mistake.
> If it was done on purpose, how is the filter supposed to be invoked now?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira