You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2011/08/11 20:42:28 UTC

[jira] [Resolved] (HADOOP-3554) LineRecordReader needs more synchronization

     [ https://issues.apache.org/jira/browse/HADOOP-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins resolved HADOOP-3554.
---------------------------------

    Resolution: Won't Fix

Out of date

> LineRecordReader needs more synchronization
> -------------------------------------------
>
>                 Key: HADOOP-3554
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3554
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.17.0
>         Environment: All java platforms
>            Reporter: Aaron Greenhouse
>         Attachments: HADOOP-3445.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> LineRecordReader has three index fields start, end, and pos.  All of these fields are long, which means that, in general, access to them is not atomic.  This can cause problems if the fields are accessed without appropriate synchronization.  
> I propose the following changes to the class:
> - Make the fields start and end final.  This requires some minor changes to the constructor LineRecordReader(Configuration, FileSplit).
> - Make the method getProgress() synchronized.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira