You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2008/11/20 16:08:46 UTC

[jira] Created: (WICKET-1945) make wicket's configuration type an enum

make wicket's configuration type an enum
----------------------------------------

                 Key: WICKET-1945
                 URL: https://issues.apache.org/jira/browse/WICKET-1945
             Project: Wicket
          Issue Type: Improvement
          Components: site
            Reporter: Peter Ertl


I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.

current:

  String org.apache.wicket.Application.getConfigurationType()

future:

    ConfigurationType org.apache.wicket.Application.getConfigurationType()

------------
  package org.apache.wicket;

  public enum ConfigurationType
  {
    DEVELOPMENT, DEPLOYMENT
  }

enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment:     (was: RuntimeConfigurationTypesEnum-eclipse-100.patch)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment: RuntimeConfigurationTypesEnum.patch

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1945:
----------------------------------

    Fix Version/s: 1.5-M2
                       (was: 1.5-M1)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M2
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment:     (was: RuntimeConfigurationTypesEnum.patch)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment: RuntimeConfigurationTypesEnum.patch

Here is a full patch converting the configuration types into a type-safe Enum.
Covers all the Wicket codebase as of revision 832322.

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-1945:
-------------------------------------

    Fix Version/s:     (was: 1.5-M3)
                   1.5-M4

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M4
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment: RuntimeConfigurationTypesEnum.patch

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment:     (was: RuntimeConfigurationTypesEnum.patch)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1945) make wicket's configuration type an enum

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649388#action_12649388 ] 

Peter Ertl commented on WICKET-1945:
------------------------------------

the best location for the enum would probably be an inner public enum of org.apache.wicket.Application

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: site
>            Reporter: Peter Ertl
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment:     (was: RuntimeConfigurationTypesEnum.patch)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1945:
----------------------------------

    Fix Version/s: 1.5-M3
                       (was: 1.5-M2)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M3
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1945:
----------------------------------

    Fix Version/s: 1.5-M1

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: site
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Comment: was deleted

(was: Uploaded the same patch, but with the provided formatting settings applied.
Also, deleted an unused local variable.)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment: RuntimeConfigurationTypesEnum.patch

Here is a full patch converting the configuration types into a type-safe Enum.
Covers all the Wicket codebase as of revision 832322.
(this time I didn't forget to add the Enum class in the patch...)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Comment: was deleted

(was: Here is a full patch converting the configuration types into a type-safe Enum.
Covers all the Wicket codebase as of revision 832322.)

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Olivier Croisier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Croisier updated WICKET-1945:
-------------------------------------

    Attachment: RuntimeConfigurationTypesEnum-eclipse-100.patch

Uploaded the same patch, but with the provided formatting settings applied.
Also, deleted an unused local variable.

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>         Attachments: RuntimeConfigurationTypesEnum-eclipse-100.patch, RuntimeConfigurationTypesEnum.patch
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1945) make wicket's configuration type an enum

Posted by "Vladimir Kovalyuk (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761743#action_12761743 ] 

Vladimir Kovalyuk commented on WICKET-1945:
-------------------------------------------

Looks inconsistent with WICKET-1847

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn Dashorst updated WICKET-1945:
-------------------------------------

    Component/s:     (was: site)
                 wicket

> make wicket's configuration type an enum
> ----------------------------------------
>
>                 Key: WICKET-1945
>                 URL: https://issues.apache.org/jira/browse/WICKET-1945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>             Fix For: 1.5-M1
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
>     ConfigurationType org.apache.wicket.Application.getConfigurationType()
> ------------
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
>     DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.