You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "dingshun3016 (via GitHub)" <gi...@apache.org> on 2024/03/14 10:36:53 UTC
[PR] [#1373][followup] fix(client):Fix task fail retry parameter not work [incubator-uniffle]
dingshun3016 opened a new pull request, #1581:
URL: https://github.com/apache/incubator-uniffle/pull/1581
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1373][followup] fix(client):Fix task fail retry parameter not work [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1581:
URL: https://github.com/apache/incubator-uniffle/pull/1581#issuecomment-1997194845
## Test Results
2 340 files ±0 2 340 suites ±0 4h 33m 32s :stopwatch: + 1m 36s
908 tests ±0 907 :white_check_mark: ±0 1 :zzz: ±0 0 :x: ±0
10 541 runs ±0 10 527 :white_check_mark: ±0 14 :zzz: ±0 0 :x: ±0
Results for commit 8583a422. ± Comparison against base commit f6569b04.
[test-results]:data:application/gzip;base64,H4sIAOPa8mUC/03MTQ6DIBCG4asY1l3ACA72Mg0/kpCqNAgr07sXjVKW38Pw7sT5edrIs4Oe00dHtuxTu22OKvmwFmEDZ1CovKfjYqTyXq8tG3MS/untP8evCk75uQCtMMUY4iUxr0eTUcHZNe9oMcBqV5Xf0FTP3UZNWBafyiBSyF5xACetsA4omola5KPQTKNB7PUgQDtLvj9mKKrSEgEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1373][followup] fix(client):Fix task fail retry parameter not work [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1581:
URL: https://github.com/apache/incubator-uniffle/pull/1581#issuecomment-1997151327
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1581?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 55.15%. Comparing base [(`f6569b0`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/f6569b046d2a1c0ec95fb390fe36f17c43aec052?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8583a42`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1581?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1581 +/- ##
============================================
+ Coverage 53.99% 55.15% +1.15%
+ Complexity 2862 2471 -391
============================================
Files 438 379 -59
Lines 24819 17526 -7293
Branches 2111 1589 -522
============================================
- Hits 13402 9667 -3735
+ Misses 10578 7309 -3269
+ Partials 839 550 -289
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1581?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1373][followup] fix(client):Fix task fail retry parameter not work [incubator-uniffle]
Posted by "dingshun3016 (via GitHub)" <gi...@apache.org>.
dingshun3016 closed pull request #1581: [#1373][followup] fix(client):Fix task fail retry parameter not work
URL: https://github.com/apache/incubator-uniffle/pull/1581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org