You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/06/22 23:24:05 UTC
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17625
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
[thirdparty] upgrade libunwind to 1.5.0
With libunwind upgraded up to 1.5.0 version, it's now possible to build
it with GCC 10.
Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/17625/1
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17625 )
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Jun 2021 23:41:40 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17625 )
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
Patch Set 2: Verified+1
unrelated test failure in org.apache.kudu.client.TestKuduMetrics
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jun 2021 04:44:01 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17625 )
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
Patch Set 2: Code-Review+2
Carrying over Andrew's and Grant's +2 from PS1.
TSAN build issues have been addressed.
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jun 2021 05:22:03 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17625 )
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
[thirdparty] upgrade libunwind to 1.5.0
With libunwind upgraded up to 1.5.0 version, it's now possible to build
it with GCC 10.
Another thing to note: libunwind 1.5.0 supports zlibdebuginfo feature
and zlib is needed for that, so I moved zlib in the list of components
before libunwind.
Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Reviewed-on: http://gerrit.cloudera.org:8080/17625
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
3 files changed, 7 insertions(+), 6 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17625
to look at the new patch set (#2).
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
[thirdparty] upgrade libunwind to 1.5.0
With libunwind upgraded up to 1.5.0 version, it's now possible to build
it with GCC 10.
Another thing to note: libunwind 1.5.0 supports zlibdebuginfo feature
and zlib is needed for that, so I moved zlib in the list of components
before libunwind.
Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
---
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/vars.sh
3 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/17625/2
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] upgrade libunwind to 1.5.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17625 )
Change subject: [thirdparty] upgrade libunwind to 1.5.0
......................................................................
Patch Set 1: Code-Review+2
Looks like there may be a TSAN issue.
--
To view, visit http://gerrit.cloudera.org:8080/17625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5964776133134d8ab17d69fc7ee0bc7457f98626
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jun 2021 02:11:58 +0000
Gerrit-HasComments: No