You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2023/03/28 05:42:18 UTC
[GitHub] [ozone] ashishkumar50 opened a new pull request, #4485: HDDS-8293. In Network Topology documentation remove DNS configuration from Topology table mapping file.
ashishkumar50 opened a new pull request, #4485:
URL: https://github.com/apache/ozone/pull/4485
## What changes were proposed in this pull request?
Update documentation by removing DNS configuration from Topology table static mapping file.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8293
## How was this patch tested?
Checked in preview in IDE. Later will verify in edge(Master).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #4485: HDDS-8293. In Network Topology documentation remove DNS configuration from Topology table mapping file.
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #4485:
URL: https://github.com/apache/ozone/pull/4485#issuecomment-1488120244
LGTM +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #4485: HDDS-8293. In Network Topology documentation remove DNS configuration from Topology table mapping file.
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi merged PR #4485:
URL: https://github.com/apache/ozone/pull/4485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ashishkumar50 commented on a diff in pull request #4485: HDDS-8293. In Network Topology documentation remove DNS configuration from Topology table mapping file.
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on code in PR #4485:
URL: https://github.com/apache/ozone/pull/4485#discussion_r1151398174
##########
hadoop-hdds/docs/content/feature/Topology.md:
##########
@@ -54,7 +54,7 @@ Static list can be configured with the help of ```TableMapping```:
</property>
```
-The second configuration option should point to a text file. The file format is a two column text file, with columns separated by whitespace. The first column is a DNS or IP address and the second column specifies the rack where the address maps. If no entry corresponding to a host in the cluster is found, then `/default-rack` is assumed.
+The second configuration option should point to a text file. The file format is a two column text file, with columns separated by whitespace. The first column is IP address and the second column specifies the rack where the address maps. If no entry corresponding to a host in the cluster is found, then `/default-rack` is assumed.
Review Comment:
Hi @adoroszlai , thanks for the review. CachedDNSToSwitchMapping only supports IP address confirmed with @ChenSammi .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4485: HDDS-8293. In Network Topology documentation remove DNS configuration from Topology table mapping file.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4485:
URL: https://github.com/apache/ozone/pull/4485#discussion_r1150203207
##########
hadoop-hdds/docs/content/feature/Topology.md:
##########
@@ -54,7 +54,7 @@ Static list can be configured with the help of ```TableMapping```:
</property>
```
-The second configuration option should point to a text file. The file format is a two column text file, with columns separated by whitespace. The first column is a DNS or IP address and the second column specifies the rack where the address maps. If no entry corresponding to a host in the cluster is found, then `/default-rack` is assumed.
+The second configuration option should point to a text file. The file format is a two column text file, with columns separated by whitespace. The first column is IP address and the second column specifies the rack where the address maps. If no entry corresponding to a host in the cluster is found, then `/default-rack` is assumed.
Review Comment:
This text, including support for DNS addresses, is adapted from `TableMapping` javadoc.
https://github.com/apache/hadoop/blob/a585a73c3e02ac62350c136643a5e7f6095a3dbb/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/TableMapping.java#L42-L53
Where is the limitation of "only IP address is supported" is coming from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org