You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by David Crossley <cr...@apache.org> on 2006/02/01 07:15:21 UTC
Re: Supporting "conditional GET" in Cocoon
On Fri, Dec 30, 2005 at 05:21:22PM +0100, Ugo Cei wrote:
> Il giorno 30/dic/05, alle ore 16:09, Sylvain Wallez ha scritto:
>
> >>>I don't understand why you need a ThreadLocal. Isn't a class
> >>>member good enough?
> >>
> >>How would a class member work with multiple threads?
> >
> >I see. This is because the HttpSource is referenced by the
> >HttpSourceValidity, right? Now the serialization problem shows that
> >it may not the right approach. Hmm.... what about using an common
> >class used both by the source and validity classes to hold the
> >common information?
>
> I was assuming that by "class member" you meant a static class
> variable. That's where my doubts about multithreading arose.
>
> >>This works for file: URLs but fails for http: URLs, which was
> >>totally unexpected to me and the cause of much frustration.
> >
> >Weird. Don't we get an exception of some kind on 404?
>
> For a file: source we get a ResourceNotFoundException, but for an
> http: source we get a ProcessingException that wraps an IOException.
>
> >Indeed. My impression is that this work is concentrated it two main
> >locations: the http source for incoming streams, and the pipeline
> >engine for outgoing streams where we must better handle etags and
> >last-modified headers.
>
> Right.
>
> I'm going on vacation in a few minutes, and I don't think I'll be
> able to contribute much to this discussion or code in the next days,
> but I'll catch up when I'm back if this thread goes on.
Resurrecting this important thread ...
I tried your patch today. Nice.
http://issues.apache.org/jira/browse/COCOON-1726
However i am not expert enough to comment on the
implementation. All that i can say is: please.
-David
Re: Supporting "conditional GET" in Cocoon
Posted by Ugo Cei <ug...@apache.org>.
Il giorno 03/feb/06, alle ore 00:32, David Crossley ha scritto:
> I got it a few days ago. Perhaps you re-attached the
> same patch.
Took a while for me to find the time to do something about this, but
I have a new version of the patch attached to the issue. You might
want to test it.
Ugo
--
Ugo Cei
Blog: http://agylen.com/
Open Source Zone: http://oszone.org/
Evil or Not?: http://evilornot.info/
Company: http://www.sourcesense.com/
Re: Supporting "conditional GET" in Cocoon
Posted by David Crossley <cr...@apache.org>.
Ugo Cei wrote:
> David Crossley ha scritto:
>
> >When a Cocoon transformer stylesheet is modified,
> >then the next browser request gets this error:
> > org.apache.commons.httpclient.HttpException: Already used, but not
> >recycled.
> >After a browser page reload, Cocoon fetches the http
> >source again, and all is fine until the next modification.
>
> I thought I had fixed this. Did you get the patch before or after
> Dec. 30? I posted a modified version on that date.
>
> Anyway, I'm a bit busy at the moment. I hope to find some time next
> week to resurrect this important discussion.
I got it a few days ago. Perhaps you re-attached the
same patch.
-David
Re: Supporting "conditional GET" in Cocoon
Posted by Ugo Cei <ug...@apache.org>.
Il giorno 02/feb/06, alle ore 06:09, David Crossley ha scritto:
> When a Cocoon transformer stylesheet is modified,
> then the next browser request gets this error:
> org.apache.commons.httpclient.HttpException: Already used, but not
> recycled.
> After a browser page reload, Cocoon fetches the http
> source again, and all is fine until the next modification.
I thought I had fixed this. Did you get the patch before or after
Dec. 30? I posted a modified version on that date.
Anyway, I'm a bit busy at the moment. I hope to find some time next
week to resurrect this important discussion.
Ugo
--
Ugo Cei
Tech Blog: http://agylen.com/
Open Source Zone: http://oszone.org/
Re: Supporting "conditional GET" in Cocoon
Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
>
> Resurrecting this important thread ...
>
> I tried your patch today. Nice.
> http://issues.apache.org/jira/browse/COCOON-1726
> However i am not expert enough to comment on the
> implementation. All that i can say is: please.
Ah, there is a problem, which i suppose is one
reason that you have not committed this.
When a Cocoon transformer stylesheet is modified,
then the next browser request gets this error:
org.apache.commons.httpclient.HttpException: Already used, but not recycled.
After a browser page reload, Cocoon fetches the http
source again, and all is fine until the next modification.
-David