You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/11 09:42:49 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #11268: Add synchronization for reporting execute process unit and enable DML statement reporting

sandynz opened a new pull request #11268:
URL: https://github.com/apache/shardingsphere/pull/11268


   Fixes #9568 part 9.
   
   Changes proposed in this pull request:
   - Add synchronization for reporting execute process unit. In order to avoid process overwriting in governance when sharded sqls are executed concurrently.
   - Enable DML statement reporting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #11268: Add synchronization for reporting execute process unit and enable DML statement reporting

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11268:
URL: https://github.com/apache/shardingsphere/pull/11268#issuecomment-877783641


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11268](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f29811) into [master](https://codecov.io/gh/apache/shardingsphere/commit/002863ec55531dccd1195fed901ba74e6b6e2079?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002863e) will **decrease** coverage by `10.48%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11268/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #11268       +/-   ##
   =============================================
   - Coverage     73.76%   63.28%   -10.49%     
   - Complexity      597     1015      +418     
   =============================================
     Files          1495     2198      +703     
     Lines         23711    33559     +9848     
     Branches       4190     5879     +1689     
   =============================================
   + Hits          17491    21237     +3746     
   - Misses         5067    10631     +5564     
   - Partials       1153     1691      +538     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../visitor/format/impl/MySQLDMLFormatSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9pbXBsL015U1FMRE1MRm9ybWF0U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/executor/sql/execute/engine/raw/RawExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9yYXcvUmF3RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
   | [...r/sql/execute/engine/driver/jdbc/JDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9kcml2ZXIvamRiYy9KREJDRXhlY3V0b3IuamF2YQ==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
   | [...presenter/processor/DefaultYamlTupleProcessor.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2VuZ2luZS9yZXByZXNlbnRlci9wcm9jZXNzb3IvRGVmYXVsdFlhbWxUdXBsZVByb2Nlc3Nvci5qYXZh) | `42.85% <0.00%> (-57.15%)` | :arrow_down: |
   | [...or/statement/impl/MySQLDCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMRENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `43.35% <0.00%> (-52.30%)` | :arrow_down: |
   | [...packet/handshake/MySQLAuthSwitchRequestPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVxdWVzdFBhY2tldC5qYXZh) | `30.76% <0.00%> (-49.24%)` | :arrow_down: |
   | [...acket/handshake/MySQLAuthSwitchResponsePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVzcG9uc2VQYWNrZXQuamF2YQ==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
   | [...atement/impl/PostgreSQLDMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `40.00% <0.00%> (-41.73%)` | :arrow_down: |
   | [...r/sql/common/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2NvbHVtbi9Db2x1bW5TZWdtZW50LmphdmE=) | `33.33% <0.00%> (-41.67%)` | :arrow_down: |
   | [...er/jdbc/adapter/executor/ForceExecuteTemplate.java](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvZXhlY3V0b3IvRm9yY2VFeGVjdXRlVGVtcGxhdGUuamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | ... and [2100 more](https://codecov.io/gh/apache/shardingsphere/pull/11268/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ff85b7b...7f29811](https://codecov.io/gh/apache/shardingsphere/pull/11268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #11268: Add synchronization for reporting execute process unit and enable DML statement reporting

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11268:
URL: https://github.com/apache/shardingsphere/pull/11268


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org