[GitHub] [iceberg] kbendick commented on pull request #4553: [WIP] Add Support For Flink 1.15

[GitBox <gi...@apache.org>]

kbendick commented on PR #4553:
URL: https://github.com/apache/iceberg/pull/4553#issuecomment-1098345892

   The following one test, `org.apache.iceberg.flink.TestChangeLogTable#testChangeLogOnDataKey` (both partitioned and unpartitioned) is failing. It _does_ relate somewhat to updated parts of the code (marked by the comment `// UPDATE`).
   
   In this test, the primary key fo the changelog table is the same as the partition schema (vs a subset).
   
   ```
   org.apache.iceberg.flink.TestChangeLogTable > testChangeLogOnDataKey[PartitionedTable=true] FAILED
       java.lang.AssertionError: Should have the expected records for the checkpoint#2 expected:<[Record(1, aaa), Record(2, ccc), Record(2, aaa), Record(1, ccc)]> but was:<[Record(1, aaa), Record(2, bbb), Record(2, ccc), Record(2, aaa), Record(1, bbb, 1, false), Record(1, ccc)]>
           at org.junit.Assert.fail(Assert.java:89)
           at org.junit.Assert.failNotEquals(Assert.java:835)
           at org.junit.Assert.assertEquals(Assert.java:120)
           at org.apache.iceberg.flink.TestChangeLogTable.testSqlChangeLog(TestChangeLogTable.java:285)
           at org.apache.iceberg.flink.TestChangeLogTable.testChangeLogOnDataKey(TestChangeLogTable.java:167)
   
   org.apache.iceberg.flink.TestChangeLogTable > testChangeLogOnDataKey[PartitionedTable=false] FAILED
       java.lang.AssertionError: Should have the expected records for the checkpoint#2 expected:<[Record(1, aaa), Record(2, ccc), Record(2, aaa), Record(1, ccc)]> but was:<[Record(1, aaa), Record(2, bbb), Record(2, ccc), Record(2, aaa), Record(1, bbb, 2, false), Record(1, ccc)]>
           at org.junit.Assert.fail(Assert.java:89)
           at org.junit.Assert.failNotEquals(Assert.java:835)
           at org.junit.Assert.assertEquals(Assert.java:120)
           at org.apache.iceberg.flink.TestChangeLogTable.testSqlChangeLog(TestChangeLogTable.java:285)
           at org.apache.iceberg.flink.TestChangeLogTable.testChangeLogOnDataKey(TestChangeLogTable.java:167)
   ```
   
   cc @yittg as you recently spent time digging into the `TestFlinkUpsert` tests, which are related. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org