You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by jameskleeh <gi...@git.apache.org> on 2018/11/09 04:48:17 UTC

[GitHub] groovy pull request #820: GROOVY-8872: Populate parameter names from byte co...

GitHub user jameskleeh opened a pull request:

    https://github.com/apache/groovy/pull/820

    GROOVY-8872: Populate parameter names from byte code when available

    I'm not sure how to create a test for this. I verified the change works locally in the example project I linked and uploaded in the jira issue.
    
    I think adding or modifying a test in AsmDecompilerTest would be the best thing, but I'm not sure how to inform Groovy to compile the Java source with parameters.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jameskleeh/groovy decompiled_param_names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #820
    
----
commit b2c31ff4f3a4038d6fbd16a89e2a14e6af4f83c2
Author: jameskleeh <ja...@...>
Date:   2018-11-09T04:44:59Z

    Populate the parameter names from the byte code when available

----


---

[GitHub] groovy pull request #820: GROOVY-8872: Populate parameter names from byte co...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/820


---