You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/09/30 19:37:51 UTC
[jira] Created: (MPPMD-14) PMD should run on unit tests
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPPMD-14
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPPMD-14
Summary: PMD should run on unit tests
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-pmd-plugin
Assignee:
Reporter: Kenneth Leider
Created: Thu, 30 Sep 2004 1:36 PM
Updated: Thu, 30 Sep 2004 1:36 PM
Description:
Right now the only files under "pom.build.sourceDirectory" are checked. It would be nice is source under "pom.build.unitTestSourceDirectory" could be checked as well.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPPMD-14) PMD should run on unit tests
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPPMD-14?page=all ]
Carlos Sanchez closed MPPMD-14:
-------------------------------
Assign To: Carlos Sanchez
Resolution: Fixed
Fix Version: 1.7
Fixed, but in a different way.
See property maven.pmd.check.tests
> PMD should run on unit tests
> ----------------------------
>
> Key: MPPMD-14
> URL: http://jira.codehaus.org/browse/MPPMD-14
> Project: maven-pmd-plugin
> Type: Improvement
> Reporter: Kenneth Leider
> Assignee: Carlos Sanchez
> Fix For: 1.7
> Attachments: plugin.jelly.patch, pmd-tests.zip
>
>
> Right now the only files under "pom.build.sourceDirectory" are checked. It would be nice is source under "pom.build.unitTestSourceDirectory" could be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPPMD-14) PMD should run on unit tests
Posted by "Wim Deblauwe (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPPMD-14?page=comments#action_31436 ]
Wim Deblauwe commented on MPPMD-14:
-----------------------------------
Got the same problem, hopefully this makes it into the next release. Maybe we should have a property called 'maven.pmd.includetestdir' to tweak this behaviour.
You need something like this to do it:
<j:set var="addtestdir" value="${maven.pmd.includetestdir}"/>
<j:if test="${addtestdir == 'true'}">
<ant:echo>Including unit test directory: ${pom.build.unitTestSourceDirectory}</ant:echo>
<fileset dir="${pom.build.unitTestSourceDirectory}"/>
</j:if>
> PMD should run on unit tests
> ----------------------------
>
> Key: MPPMD-14
> URL: http://jira.codehaus.org/browse/MPPMD-14
> Project: maven-pmd-plugin
> Type: Improvement
> Reporter: Kenneth Leider
> Attachments: plugin.jelly.patch, pmd-tests.zip
>
>
> Right now the only files under "pom.build.sourceDirectory" are checked. It would be nice is source under "pom.build.unitTestSourceDirectory" could be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPPMD-14) PMD should run on unit tests
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Sebastian Esponda
Created: Wed, 13 Oct 2004 11:21 AM
Body:
Right!...It would be nice. I've temporary edited plugin.jelly and duplicated the fileset section with:
<fileset dir="${pom.build.unitTestSourceDirectory}" ...
...
Regards!
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPPMD-14?page=comments#action_25320
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPPMD-14
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPPMD-14
Summary: PMD should run on unit tests
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-pmd-plugin
Assignee:
Reporter: Kenneth Leider
Created: Thu, 30 Sep 2004 1:36 PM
Updated: Wed, 13 Oct 2004 11:21 AM
Description:
Right now the only files under "pom.build.sourceDirectory" are checked. It would be nice is source under "pom.build.unitTestSourceDirectory" could be checked as well.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPPMD-14) PMD should run on unit tests
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Sebastian Esponda (mailto:sesponda@gmail.com)
Date: Tue, 19 Oct 2004 12:58 PM
Comment:
We needed PMD to analyze our tests sources, so we did some changes:
Plugin.jelly:
If ${pom.build.unitTestSourceDirectory} points to a valid directory, a second fileset is included in pmd ant task.
Plugin.jsl:
The original file always used <a href="xref/... etc > when linking line numbers to sources. This failed for tests sources.
Now, if the file path starts with ${pom.build.unitTestSourceDirectory} the link will be <a href="xref-test/... etc >
In the zip file Im including:
New plugin.jelly
New plugin.jsl
Patch for plugin.jelly 1.15 (Previously posted, included here for convenience)
Patch for plugin.jsl 1.4
... just in case you find it useful (hope so)
Ive just learned jsl and jelly... so this is probably with bugs... but its working ok in our environment ;)
Regards,
Changes:
Attachment changed to pmd-tests.zip
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPPMD-14?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPPMD-14
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPPMD-14
Summary: PMD should run on unit tests
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-pmd-plugin
Assignee:
Reporter: Kenneth Leider
Created: Thu, 30 Sep 2004 1:36 PM
Updated: Tue, 19 Oct 2004 12:58 PM
Description:
Right now the only files under "pom.build.sourceDirectory" are checked. It would be nice is source under "pom.build.unitTestSourceDirectory" could be checked as well.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPPMD-14) PMD should run on unit tests
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Sebastian Esponda (mailto:sesponda@gmail.com)
Date: Fri, 15 Oct 2004 4:52 PM
Comment:
This CVS patch will add a fileset including the tests (pom.build.unitTestSourceDirectory), only if the properties points to a valid directory.
Created editing version 1.15.
Regards,
Changes:
Attachment changed to plugin.jelly.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPPMD-14?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPPMD-14
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPPMD-14
Summary: PMD should run on unit tests
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-pmd-plugin
Assignee:
Reporter: Kenneth Leider
Created: Thu, 30 Sep 2004 1:36 PM
Updated: Fri, 15 Oct 2004 4:52 PM
Description:
Right now the only files under "pom.build.sourceDirectory" are checked. It would be nice is source under "pom.build.unitTestSourceDirectory" could be checked as well.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org