You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org> on 2012/03/16 11:29:40 UTC
[jira] [Commented] (SLING-2439) Move Launchpad API embedding to
launchpad base bundle
[ https://issues.apache.org/jira/browse/SLING-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231031#comment-13231031 ]
Carsten Ziegeler commented on SLING-2439:
-----------------------------------------
lgtm, +1
> Move Launchpad API embedding to launchpad base bundle
> -----------------------------------------------------
>
> Key: SLING-2439
> URL: https://issues.apache.org/jira/browse/SLING-2439
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.3.0
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.4.0
>
> Attachments: SLING-2439.patch
>
>
> Currently the Launchpad API classes are in the Launchpad Base launcher code (standalone app or web app) and are "inherited" through the class loader hierarchy by the launchpad base bundle and exposed through system bundle exports into the OSGi Framework. This would be ok, if the launcher would actually use/require the launchpad API. This is not the case.
> On the other hand, this setup prevents updating existing Sling setups with a new launchpad base bundle because newer builds require up-to-date launchpad API.
> Since the launcher does not use the launchpad API it is more appropriate to actually include the launchpad API with the Launchpad Base bundle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira