You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/28 00:02:01 UTC
[GitHub] [yunikorn-site] wilfred-s commented on a change in pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
wilfred-s commented on a change in pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144#discussion_r835982586
##########
File path: src/pages/community/release_procedure.md
##########
@@ -34,12 +34,13 @@ The instructions and tools obey the ASF [release policy](http://www.apache.org/l
* [Run the release tool](#run-the-release-tool)
* [Create Signature](#create-signature)
* [Create Checksum](#create-checksum)
- * [Upload Release Candidate Artefacts](#upload-release-candidate-artefacts)
+ * [Upload Release Candidate Artifacts](#upload-release-candidate-artifacts)
* [Start Voting Thread](#start-voting-thread)
* [Publish the Release](#publish-the-release)
* [Release Docker images](#release-docker-images)
* [Release Helm Charts](#release-helm-charts)
* [Update the website](#update-the-website)
+ * [Cleanup](#Cleanup)
Review comment:
no capitals in the internal links
##########
File path: src/pages/community/release_procedure.md
##########
@@ -223,7 +225,7 @@ Older releases should be downloaded from the archive directly, not from the rele
The releases need to clean up in two locations:
* Remove the newly released version from the _dev_ area by removing the old release candidate directory.
- For the location see [release candidate location](#Upload-Release-Candidate-Artefacts)
+ For the location see [release candidate location](#Upload-Release-Candidate-Artifacts)
* Remove the non-current release from the _release_ area by removing the old release directory.
For the location see [release location](#Publish-the-Release)
Review comment:
this one needs fixing also: only lower case
##########
File path: src/pages/community/release_procedure.md
##########
@@ -187,7 +189,7 @@ Contrary to the source code tar ball signing, signing the helm charts requires m
The helm package will generate two files:
- helm package: example `yunikorn-0.8.0.tgz`
- provenance or signature file: example `yunikorn-0.8.0.tgz.prov`
-Both files should be attached to the [release in GIT](#Create-the GIT-releases) for the release repository.
+Both files should be attached to the [release in GIT](#Create-the-GIT-releases) for the release repository.
Review comment:
no capitals in the internal links
##########
File path: src/pages/community/release_procedure.md
##########
@@ -223,7 +225,7 @@ Older releases should be downloaded from the archive directly, not from the rele
The releases need to clean up in two locations:
* Remove the newly released version from the _dev_ area by removing the old release candidate directory.
- For the location see [release candidate location](#Upload-Release-Candidate-Artefacts)
+ For the location see [release candidate location](#Upload-Release-Candidate-Artifacts)
Review comment:
links needs fixing: only lower case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org