You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by anuruddhal <gi...@git.apache.org> on 2015/05/18 12:01:24 UTC
[GitHub] stratos pull request: Fixing login error message in CLI
GitHub user anuruddhal opened a pull request:
https://github.com/apache/stratos/pull/330
Fixing login error message in CLI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anuruddhal/stratos CLI
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #330
----
commit 76082fe1e88f5facfcbfa4afed4f32a97c10e6a8
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-15T08:42:51Z
Fixing Cartridge Remove issue
commit 706f0baec62397634979ac42c6cd6493f74b1e31
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-15T08:53:54Z
Fixing group alias in startup order
commit 22aac9b711113c40bbc6b675f0891a489b8d60eb
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-15T08:55:21Z
Merge remote-tracking branch 'upstream/master'
commit cc1a6ea5e1f8e3325a92ab708bde1cac2fdb119b
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-15T12:33:32Z
Merge remote-tracking branch 'upstream/master'
commit 248d4b46b90c4151706730faf4214cd38a68afb5
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-15T15:05:50Z
Merge remote-tracking branch 'upstream/master'
commit eb803c17cb1417aecb95160883a5fc450f6d68c0
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-18T04:13:42Z
Merge remote-tracking branch 'upstream/master'
commit b7d4c7fee769af98999a3e29826d0f4561e1c60f
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-18T05:59:46Z
Merge remote-tracking branch 'upstream/master'
commit b5858541e5e53b49af1d650c8a2c166e00284ea3
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-18T06:02:14Z
Merge remote-tracking branch 'upstream/master'
commit 7604fd6545e26ca807a5ad5700c976fef9f6bec1
Author: anuruddhal <an...@gmail.com>
Date: 2015-05-18T09:52:54Z
Fixing login error in CLI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixing login error message in CLI
Posted by prabathabey <gi...@git.apache.org>.
Github user prabathabey commented on a diff in the pull request:
https://github.com/apache/stratos/pull/330#discussion_r35574468
--- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java ---
@@ -214,7 +215,7 @@ public void checkServerTrusted(java.security.cert.X509Certificate[] certs, Strin
if (responseCode == 200) {
return true;
} else {
- System.out.println("Invalid STRATOS_URL");
+ System.out.println("Invalid value is set for STRATOS_URL");
--- End diff --
Maybe we can use "printError" error handler method here as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixing login error message in CLI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/stratos/pull/330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixing login error message in CLI
Posted by anuruddhal <gi...@git.apache.org>.
Github user anuruddhal commented on a diff in the pull request:
https://github.com/apache/stratos/pull/330#discussion_r35615504
--- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java ---
@@ -214,7 +215,7 @@ public void checkServerTrusted(java.security.cert.X509Certificate[] certs, Strin
if (responseCode == 200) {
return true;
} else {
- System.out.println("Invalid STRATOS_URL");
+ System.out.println("Invalid value is set for STRATOS_URL");
--- End diff --
printError method can be only used to print errors with exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixing login error message in CLI
Posted by lafernando <gi...@git.apache.org>.
Github user lafernando commented on a diff in the pull request:
https://github.com/apache/stratos/pull/330#discussion_r36069108
--- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java ---
@@ -214,7 +215,7 @@ public void checkServerTrusted(java.security.cert.X509Certificate[] certs, Strin
if (responseCode == 200) {
return true;
} else {
- System.out.println("Invalid STRATOS_URL");
+ System.out.println("Invalid value is set for STRATOS_URL");
--- End diff --
Create an overloaded "printError" method, which doesn't take an exception object. Having sysouts and another method to log errors makes it inconsistent on how you handle printing of errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---