You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:38:46 UTC

[GitHub] [arrow] romainfrancois commented on a change in pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r520380853



##########
File path: r/src/arrow_cpp11.h
##########
@@ -300,22 +297,65 @@ bool GetBoolOption(const std::string& name, bool default_);
 namespace cpp11 {
 
 template <typename T>
-using enable_if_shared_ptr = typename std::enable_if<
-    std::is_same<std::shared_ptr<typename T::element_type>, T>::value, T>::type;
+std::string r6_class_name(const std::shared_ptr<T>& x);

Review comment:
       Oh interesting, I had not seen `nameof()` before. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org