You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/10 10:58:03 UTC
[GitHub] [rocketmq] duhenglucky opened a new pull request #1765: Committed
with namespace fix
duhenglucky opened a new pull request #1765: Committed with namespace fix
URL: https://github.com/apache/rocketmq/pull/1765
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on a change in pull request #1765:
[ISSUE #1766]Reduce the pause time caused by pause
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #1765: [ISSUE #1766]Reduce the pause time caused by pause
URL: https://github.com/apache/rocketmq/pull/1765#discussion_r401486668
##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
##########
@@ -399,6 +399,17 @@ private void startPullTask(Collection<MessageQueue> mqSet) {
}
}
+ private void updatePullTask(MessageQueue messageQueue) {
Review comment:
agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #1765:
[ISSUE #1766]Reduce the pause time caused by pause
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #1765: [ISSUE #1766]Reduce the pause time caused by pause
URL: https://github.com/apache/rocketmq/pull/1765#discussion_r377048434
##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
##########
@@ -399,6 +399,17 @@ private void startPullTask(Collection<MessageQueue> mqSet) {
}
}
+ private void updatePullTask(MessageQueue messageQueue) {
Review comment:
Maybe rename “resetPullTask” better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1765: [ISSUE #1766]Reduce
the pause time caused by pause
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1765: [ISSUE #1766]Reduce the pause time caused by pause
URL: https://github.com/apache/rocketmq/pull/1765#issuecomment-584117399
[](https://coveralls.io/builds/28630505)
Coverage increased (+0.03%) to 50.928% when pulling **741978b801fc0c2ea9655a65e8f08c74734b7846 on duhenglucky:committed_namespace_fix** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services