You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/29 00:45:27 UTC

[GitHub] [beam] TheNeuralBit commented on pull request #13622: [BEAM-11530] Annotated setter parameters handled wrong in schema creation

TheNeuralBit commented on pull request #13622:
URL: https://github.com/apache/beam/pull/13622#issuecomment-751907821


   Thanks for the contribution @krakowski! It looks like this change actually breaks our existing test though: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/15285/testReport/junit/org.apache.beam.sdk.schemas/JavaBeanSchemaTest/testNullableToRow/
   
   Maybe if you add a test for your use case to `JavaBeanSchemaTest` we can find a fix that works for both?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org