[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #7507: Fixed filter for status in task table
URL: https://github.com/apache/incubator-druid/pull/7507#discussion_r276864728
 
 

 ##########
 File path: web-console/src/utils/general.tsx
 ##########
 @@ -66,13 +66,11 @@ export function makeBooleanFilter(): FilterRender {
   };
 }
 
-export function customTableFilter(filter: Filter, row?: any): boolean | string {
-  const id = filter.pivotId || filter.id;
-  const clientSideFilter: boolean = row !== undefined;
-  if (clientSideFilter && row[id] === undefined) {
+export function customTableFilter(filter: Filter, clientSideFilter: boolean, value?: any): boolean | string {
 
 Review comment:
   This function has no clear meaning, could you please refactor this into two functions one for `clientSideFilter` `true` and one for `false`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org