You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/11/18 16:34:17 UTC

svn commit: r1883607 - in /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel: ./ common/ common/function/

Author: lehmi
Date: Wed Nov 18 16:34:17 2020
New Revision: 1883607

URL: http://svn.apache.org/viewvc?rev=1883607&view=rev
Log:
PDFBOX-5017: sonar fix

Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageLayoutTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageModeTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestFDF.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentInformation.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageAnnotationsFiltering.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageContentStream.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTransitions.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTree.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/PDStreamTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestEmbeddedFiles.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNameTreeNode.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNumberTreeNode.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/function/TestPDFunctionType4.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageLayoutTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageLayoutTest.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageLayoutTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageLayoutTest.java Wed Nov 18 16:34:17 2020
@@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Asse
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import org.junit.jupiter.api.Test;
 
-public class PageLayoutTest
+class PageLayoutTest
 {
     /**
      * @author Tilman Hausherr
@@ -30,7 +30,7 @@ public class PageLayoutTest
      * Test for completeness (PDFBOX-3362).
      */
     @Test
-    public void testValues()
+    void testValues()
     {
         Set<PageLayout> pageLayoutSet = EnumSet.noneOf(PageLayout.class);
         Set<String> stringSet = new HashSet<>();
@@ -48,7 +48,7 @@ public class PageLayoutTest
      * @author John Bergqvist
      */
     @Test
-    public void fromStringInputNotNullOutputIllegalArgumentException()
+    void fromStringInputNotNullOutputIllegalArgumentException()
     {
         assertThrows(IllegalArgumentException.class, () -> PageLayout.fromString("SinglePag"));
     }

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageModeTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageModeTest.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageModeTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/PageModeTest.java Wed Nov 18 16:34:17 2020
@@ -21,10 +21,10 @@ import static org.junit.jupiter.api.Asse
 
 import org.junit.jupiter.api.Test;
 
-public class PageModeTest
+class PageModeTest
 {
     @Test
-    public void fromStringInputNotNullOutputNotNull()
+    void fromStringInputNotNullOutputNotNull()
     {
         // Arrange
         final String value = "FullScreen";
@@ -37,7 +37,7 @@ public class PageModeTest
     }
 
     @Test
-    public void fromStringInputNotNullOutputNotNull2()
+    void fromStringInputNotNullOutputNotNull2()
     {
         // Arrange
         final String value = "UseThumbs";
@@ -50,7 +50,7 @@ public class PageModeTest
     }
 
     @Test
-    public void fromStringInputNotNullOutputNotNull3()
+    void fromStringInputNotNullOutputNotNull3()
     {
         // Arrange
         final String value = "UseOC";
@@ -63,7 +63,7 @@ public class PageModeTest
     }
 
     @Test
-    public void fromStringInputNotNullOutputNotNull4()
+    void fromStringInputNotNullOutputNotNull4()
     {
         // Arrange
         final String value = "UseNone";
@@ -76,7 +76,7 @@ public class PageModeTest
     }
 
     @Test
-    public void fromStringInputNotNullOutputNotNull5()
+    void fromStringInputNotNullOutputNotNull5()
     {
         // Arrange
         final String value = "UseAttachments";
@@ -89,7 +89,7 @@ public class PageModeTest
     }
 
     @Test
-    public void fromStringInputNotNullOutputNotNull6()
+    void fromStringInputNotNullOutputNotNull6()
     {
         // Arrange
         final String value = "UseOutlines";
@@ -102,19 +102,19 @@ public class PageModeTest
     }
 
     @Test
-    public void fromStringInputNotNullOutputIllegalArgumentException()
+    void fromStringInputNotNullOutputIllegalArgumentException()
     {
         assertThrows(IllegalArgumentException.class, () -> PageMode.fromString(""));
     }
 
     @Test
-    public void fromStringInputNotNullOutputIllegalArgumentException2()
+    void fromStringInputNotNullOutputIllegalArgumentException2()
     {
         assertThrows(IllegalArgumentException.class, () -> PageMode.fromString("Dulacb`ecj"));
     }
 
     @Test
-    public void stringValueOutputNotNull()
+    void stringValueOutputNotNull()
     {
         // Arrange
         final PageMode objectUnderTest = PageMode.USE_OPTIONAL_CONTENT;

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestFDF.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestFDF.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestFDF.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestFDF.java Wed Nov 18 16:34:17 2020
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
  * @author Tilman Hausherr
  * 
  */
-public class TestFDF
+class TestFDF
 {
     /**
      * Test load two simple fdf files with two fields. One of the files does not have a
@@ -48,7 +48,7 @@ public class TestFDF
      * @throws IOException
      */
     @Test
-    public void testLoad2() throws URISyntaxException, IOException
+    void testLoad2() throws URISyntaxException, IOException
     {
         checkFields("/org/apache/pdfbox/pdfparser/withcatalog.fdf");
         checkFields("/org/apache/pdfbox/pdfparser/nocatalog.fdf");

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java Wed Nov 18 16:34:17 2020
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test;
  * Test case introduced with PDFBOX-1581.
  * 
  */
-public class TestPDDocument
+class TestPDDocument
 {
     static private final File TESTRESULTSDIR = new File("target/test-output");
 
@@ -56,7 +56,7 @@ public class TestPDDocument
      * @throws IOException if something went wrong
      */
     @Test
-    public void testSaveLoadStream() throws IOException
+    void testSaveLoadStream() throws IOException
     {
         ByteArrayOutputStream baos;
         // Create PDF with one blank page
@@ -86,7 +86,7 @@ public class TestPDDocument
      * @throws IOException if something went wrong
      */
     @Test
-    public void testSaveLoadFile() throws IOException
+    void testSaveLoadFile() throws IOException
     {
         File targetFile = new File(TESTRESULTSDIR, "pddocument-saveloadfile.pdf");
 
@@ -118,7 +118,7 @@ public class TestPDDocument
      * @throws IOException if something went wrong
      */
     @Test
-    public void testVersions() throws IOException
+    void testVersions() throws IOException
     {
         // test default version
         try (PDDocument document = new PDDocument())
@@ -162,7 +162,7 @@ public class TestPDDocument
      * @throws java.io.IOException
      */
     @Test
-    public void testDeleteBadFile() throws IOException
+    void testDeleteBadFile() throws IOException
     {
         File f = new File(TESTRESULTSDIR, "testDeleteBadFile.pdf");
         System.out.println("f: " + f.getAbsolutePath());
@@ -187,7 +187,7 @@ public class TestPDDocument
      * @throws java.io.IOException
      */
     @Test
-    public void testDeleteGoodFile() throws IOException
+    void testDeleteGoodFile() throws IOException
     {
         File f = new File(TESTRESULTSDIR, "testDeleteGoodFile.pdf");
         try (PDDocument doc = new PDDocument())
@@ -215,7 +215,7 @@ public class TestPDDocument
      * @throws java.io.IOException
      */
     @Test
-    public void testSaveArabicLocale() throws IOException
+    void testSaveArabicLocale() throws IOException
     {
         Locale defaultLocale = Locale.getDefault();
         Locale arabicLocale = new Locale.Builder().setLanguageTag("ar-EG-u-nu-arab").build();

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java Wed Nov 18 16:34:17 2020
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
  * Test PDDocument Catalog functionality.
  *
  */
-public class TestPDDocumentCatalog
+class TestPDDocumentCatalog
 {
 
     /**
@@ -47,7 +47,7 @@ public class TestPDDocumentCatalog
      * @throws IOException in case the document can not be parsed.
      */
     @Test
-    public void retrievePageLabels() throws IOException
+    void retrievePageLabels() throws IOException
     {
         PDDocument doc = null;
         try
@@ -89,7 +89,7 @@ public class TestPDDocumentCatalog
      * @throws IOException in case the document can not be parsed.
      */
     @Test
-    public void retrievePageLabelsOnMalformedPdf() throws IOException
+    void retrievePageLabelsOnMalformedPdf() throws IOException
     {
         PDDocument doc = null;
         try
@@ -120,7 +120,7 @@ public class TestPDDocumentCatalog
      * @throws IOException in case the document can not be parsed.
      */
     @Test
-    public void retrieveNumberOfPages() throws IOException
+    void retrieveNumberOfPages() throws IOException
     {
         PDDocument doc = null;
         try
@@ -147,7 +147,7 @@ public class TestPDDocumentCatalog
      * @throws IOException in case the document can not be parsed.
      */
     @Test
-    public void handleOutputIntents() throws IOException
+    void handleOutputIntents() throws IOException
     {
         PDDocument doc = null;
         InputStream colorProfile = null;
@@ -196,7 +196,7 @@ public class TestPDDocumentCatalog
     }
 
     @Test
-    public void handleBooleanInOpenAction() throws IOException
+    void handleBooleanInOpenAction() throws IOException
     {
         //PDFBOX-3772 -- allow for COSBoolean
         PDDocument doc = new PDDocument();

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentInformation.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentInformation.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentInformation.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentInformation.java Wed Nov 18 16:34:17 2020
@@ -33,11 +33,11 @@ import org.junit.jupiter.api.Test;
  * @author Neil McErlean
  * @since 1.3.0
  */
-public class TestPDDocumentInformation
+class TestPDDocumentInformation
 {
 
     @Test
-    public void testMetadataExtraction() throws Exception
+    void testMetadataExtraction() throws Exception
     {
         // This document has been selected for this test as it contains custom metadata.
         try (PDDocument doc = Loader.loadPDF(new File("src/test/resources/input/hello3.pdf")))
@@ -77,7 +77,7 @@ public class TestPDDocumentInformation
      * @throws Exception 
      */
     @Test
-    public void testPDFBox3068() throws Exception
+    void testPDFBox3068() throws Exception
     {
         try (PDDocument doc = Loader
                 .loadPDF(TestPDDocumentInformation.class.getResourceAsStream("PDFBOX-3068.pdf")))

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageAnnotationsFiltering.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageAnnotationsFiltering.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageAnnotationsFiltering.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageAnnotationsFiltering.java Wed Nov 18 16:34:17 2020
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
  * @author <a href="mailto:maxime.veron.pro@gmail.com">Maxime Veron</a>
  *
  */
-public class TestPDPageAnnotationsFiltering
+class TestPDPageAnnotationsFiltering
 {
     // test mock page for annotations filtering
     private PDPage page;
@@ -57,7 +57,7 @@ public class TestPDPageAnnotationsFilter
     }
 
     @Test
-    public void validateNoFiltering() throws IOException
+     void validateNoFiltering() throws IOException
     {
         List<PDAnnotation> annotations = page.getAnnotations();
         assertEquals(3, annotations.size());
@@ -67,14 +67,14 @@ public class TestPDPageAnnotationsFilter
     }
 
     @Test
-    public void validateAllFiltered() throws IOException
+     void validateAllFiltered() throws IOException
     {
         List<PDAnnotation> annotations = page.getAnnotations(annotation -> false);
         assertEquals(0, annotations.size());
     }
 
     @Test
-    public void validateSelectedFew() throws IOException
+     void validateSelectedFew() throws IOException
     {
         List<PDAnnotation> annotations = page.getAnnotations(annotation -> 
             (annotation instanceof PDAnnotationLink || annotation instanceof PDAnnotationSquare));

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageContentStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageContentStream.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageContentStream.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageContentStream.java Wed Nov 18 16:34:17 2020
@@ -30,10 +30,10 @@ import org.junit.jupiter.api.Test;
 /**
  * @author Yegor Kozlov
  */
-public class TestPDPageContentStream
+class TestPDPageContentStream
 {
     @Test
-    public void testSetCmykColors() throws IOException
+    void testSetCmykColors() throws IOException
     {
         try (PDDocument doc = new PDDocument())
         {
@@ -89,7 +89,7 @@ public class TestPDPageContentStream
     }
 
     @Test
-    public void testSetRGBandGColors() throws IOException
+    void testSetRGBandGColors() throws IOException
     {
         try (PDDocument doc = new PDDocument())
         {
@@ -142,7 +142,7 @@ public class TestPDPageContentStream
      * @throws IOException 
      */
     @Test
-    public void testMissingContentStream() throws IOException
+    void testMissingContentStream() throws IOException
     {
         PDPage page = new PDPage();
         PDFStreamParser parser = new PDFStreamParser(page);
@@ -156,7 +156,7 @@ public class TestPDPageContentStream
      * @throws IOException 
      */
     @Test
-    public void testCloseContract() throws IOException
+    void testCloseContract() throws IOException
     {
         try (PDDocument doc = new PDDocument())
         {

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTransitions.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTransitions.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTransitions.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTransitions.java Wed Nov 18 16:34:17 2020
@@ -34,11 +34,11 @@ import org.junit.jupiter.api.Test;
  * @author Andrea Vacondio
  *
  */
-public class TestPDPageTransitions
+class TestPDPageTransitions
 {
 
     @Test
-    public void readTransitions() throws IOException, URISyntaxException
+    void readTransitions() throws IOException, URISyntaxException
     {
         try (PDDocument doc = Loader.loadPDF(new File(this.getClass().getResource(
                 "/org/apache/pdfbox/pdmodel/interactive/pagenavigation/transitions_test.pdf").toURI())))
@@ -52,7 +52,7 @@ public class TestPDPageTransitions
     }
 
     @Test
-    public void saveAndReadTransitions() throws IOException
+    void saveAndReadTransitions() throws IOException
     {
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
 

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTree.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTree.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTree.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPageTree.java Wed Nov 18 16:34:17 2020
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
  * @author Andrea Vacondio
  *
  */
-public class TestPDPageTree
+class TestPDPageTree
 {
     private PDDocument doc;
 
@@ -45,7 +45,7 @@ public class TestPDPageTree
     }
 
     @Test
-    public void indexOfPageFromOutlineDestination() throws IOException
+    void indexOfPageFromOutlineDestination() throws IOException
     {
         doc = Loader.loadPDF(TestPDPageTree.class.getResourceAsStream("with_outline.pdf"));
         PDDocumentOutline outline = doc.getDocumentCatalog().getDocumentOutline();
@@ -59,7 +59,7 @@ public class TestPDPageTree
     }
 
     @Test
-    public void positiveSingleLevel() throws IOException
+    void positiveSingleLevel() throws IOException
     {
         doc = Loader.loadPDF(TestPDPageTree.class.getResourceAsStream("with_outline.pdf"));
         for (int i = 0; i < doc.getNumberOfPages(); i++)
@@ -69,7 +69,7 @@ public class TestPDPageTree
     }
 
     @Test
-    public void positiveMultipleLevel() throws IOException
+    void positiveMultipleLevel() throws IOException
     {
         doc = Loader
                 .loadPDF(TestPDPageTree.class.getResourceAsStream("page_tree_multiple_levels.pdf"));
@@ -80,14 +80,15 @@ public class TestPDPageTree
     }
 
     @Test
-    public void negative() throws IOException
+    void negative() throws IOException
     {
         doc = Loader.loadPDF(TestPDPageTree.class.getResourceAsStream("with_outline.pdf"));
         assertEquals(-1, doc.getPages().indexOf(new PDPage()));
     }
 
     @Test
-    public void testInsertBeforeBlankPage() throws Exception {
+    void testInsertBeforeBlankPage() throws Exception
+    {
         try (PDDocument document = new PDDocument()) {
             PDPage pageOne = new PDPage();
             PDPage pageTwo = new PDPage();
@@ -105,7 +106,8 @@ public class TestPDPageTree
     }
 
     @Test
-    public void testInsertAfterBlankPage() throws Exception {
+    void testInsertAfterBlankPage() throws Exception
+    {
         try (PDDocument document = new PDDocument()) {
             PDPage pageOne = new PDPage();
             PDPage pageTwo = new PDPage();

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java Wed Nov 18 16:34:17 2020
@@ -40,7 +40,8 @@ import org.apache.pdfbox.pdmodel.interac
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class COSArrayListTest {
+class COSArrayListTest
+{
     // next two entries are to be used for comparison with
     // COSArrayList behaviour in order to ensure that the
     // intended object is now at the correct position.
@@ -110,7 +111,8 @@ public class COSArrayListTest {
      * Test getting a PDModel element is in sync with underlying COSArray
      */
     @Test
-    public void getFromList() throws Exception {
+    void getFromList() throws Exception
+    {
         COSArrayList<PDAnnotation> cosArrayList = new COSArrayList<>(annotationsList, annotationsArray);
 
         for (int i = 0; i < cosArrayList.size(); i++) {
@@ -152,7 +154,8 @@ public class COSArrayListTest {
      * Test removing a PDModel element by index is in sync with underlying COSArray
      */
     @Test
-    public void removeFromListByIndex() throws Exception {
+    void removeFromListByIndex() throws Exception
+    {
         COSArrayList<PDAnnotation> cosArrayList = new COSArrayList<>(annotationsList, annotationsArray);
 
         int positionToRemove = 2;
@@ -174,7 +177,8 @@ public class COSArrayListTest {
      * COSArray
      */
     @Test
-    public void removeUniqueFromListByObject() throws Exception {
+    void removeUniqueFromListByObject() throws Exception
+    {
         COSArrayList<PDAnnotation> cosArrayList = new COSArrayList<>(annotationsList, annotationsArray);
 
         int positionToRemove = 2;
@@ -206,7 +210,8 @@ public class COSArrayListTest {
      * COSArray
      */
     @Test
-    public void removeAllUniqueFromListByObject() throws Exception {
+    void removeAllUniqueFromListByObject() throws Exception
+    {
         COSArrayList<PDAnnotation> cosArrayList = new COSArrayList<>(annotationsList, annotationsArray);
 
         int positionToRemove = 2;
@@ -228,7 +233,8 @@ public class COSArrayListTest {
      * underlying COSArray
      */
     @Test
-    public void removeMultipleFromListByObject() throws Exception {
+    void removeMultipleFromListByObject() throws Exception
+    {
         COSArrayList<PDAnnotation> cosArrayList = new COSArrayList<>(annotationsList, annotationsArray);
 
         int positionToRemove = 1;
@@ -248,7 +254,8 @@ public class COSArrayListTest {
      * COSArray
      */
     @Test
-    public void removeAllMultipleFromListByObject() throws Exception {
+    void removeAllMultipleFromListByObject() throws Exception
+    {
         COSArrayList<PDAnnotation> cosArrayList = new COSArrayList<>(annotationsList, annotationsArray);
 
         int positionToRemove = 1;
@@ -266,7 +273,8 @@ public class COSArrayListTest {
     }
 
     @Test
-    public void removeFromFilteredListByIndex() throws Exception {
+    void removeFromFilteredListByIndex() throws Exception
+    {
         // retrieve all annotations from page but the link annotation
         // which is 2nd in list - see above setup
         AnnotationFilter annotsFilter = annotation -> !(annotation instanceof PDAnnotationLink);
@@ -278,7 +286,8 @@ public class COSArrayListTest {
     }
 
     @Test
-    public void removeFromFilteredListByObject() throws Exception {
+    void removeFromFilteredListByObject() throws Exception
+    {
         // retrieve all annotations from page but the link annotation
         // which is 2nd in list - see above setup
         AnnotationFilter annotsFilter = annotation -> !(annotation instanceof PDAnnotationLink);
@@ -294,7 +303,8 @@ public class COSArrayListTest {
     }
 
     @Test
-    public void removeSingleDirectObject() throws IOException {
+    void removeSingleDirectObject() throws IOException
+    {
 
         // generate test file
         try (PDDocument pdf = new PDDocument()) {
@@ -339,7 +349,8 @@ public class COSArrayListTest {
     }
 
     @Test
-    public void removeSingleIndirectObject() throws IOException {
+    void removeSingleIndirectObject() throws IOException
+    {
 
         // generate test file
         try (PDDocument pdf = new PDDocument()) {
@@ -381,7 +392,8 @@ public class COSArrayListTest {
     }
 
     @Test
-    public void retainIndirectObject() throws IOException {
+    void retainIndirectObject() throws IOException
+    {
 
         // generate test file
         try (PDDocument pdf = new PDDocument()) {

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/PDStreamTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/PDStreamTest.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/PDStreamTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/PDStreamTest.java Wed Nov 18 16:34:17 2020
@@ -31,14 +31,14 @@ import org.junit.jupiter.api.Test;
  *
  * @author Tilman Hausherr
  */
-public class PDStreamTest
+class PDStreamTest
 {
     
     /**
      * Test for null filter list (PDFBOX-2948)
      */
     @Test
-    public void testCreateInputStreamNullFilters() throws Exception
+    void testCreateInputStreamNullFilters() throws Exception
     {
         try (PDDocument doc = new PDDocument())
         {
@@ -62,7 +62,7 @@ public class PDStreamTest
      * Test for empty filter list
      */
     @Test
-    public void testCreateInputStreamEmptyFilters() throws Exception
+    void testCreateInputStreamEmptyFilters() throws Exception
     {
         try (PDDocument doc = new PDDocument())
         {
@@ -86,7 +86,7 @@ public class PDStreamTest
      * Test for null stop filters
      */
     @Test
-    public void testCreateInputStreamNullStopFilters() throws Exception
+    void testCreateInputStreamNullStopFilters() throws Exception
     {
         try (PDDocument doc = new PDDocument())
         {

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestEmbeddedFiles.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestEmbeddedFiles.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestEmbeddedFiles.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestEmbeddedFiles.java Wed Nov 18 16:34:17 2020
@@ -36,10 +36,10 @@ import org.apache.pdfbox.pdmodel.common.
 import org.apache.pdfbox.pdmodel.common.filespecification.PDEmbeddedFile;
 import org.junit.jupiter.api.Test;
 
-public class TestEmbeddedFiles
+class TestEmbeddedFiles
 {
     @Test
-    public void testNullEmbeddedFile() throws IOException
+    void testNullEmbeddedFile() throws IOException
     {
         PDEmbeddedFile embeddedFile = null;
         boolean ok = false;
@@ -76,7 +76,7 @@ public class TestEmbeddedFiles
     }
 
     @Test
-    public void testOSSpecificAttachments() throws IOException
+    void testOSSpecificAttachments() throws IOException
     {
         PDEmbeddedFile nonOSFile = null;
         PDEmbeddedFile macFile = null;

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNameTreeNode.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNameTreeNode.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNameTreeNode.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNameTreeNode.java Wed Nov 18 16:34:17 2020
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
  * 
  * @author Koch
  */
-public class TestPDNameTreeNode
+class TestPDNameTreeNode
 {
     private PDNameTreeNode<COSInteger> node1;
     private PDNameTreeNode<COSInteger> node2;
@@ -92,7 +92,7 @@ public class TestPDNameTreeNode
     }
 
     @Test
-    public void testUpperLimit() throws IOException
+    void testUpperLimit() throws IOException
     {
         assertEquals("Astatine", this.node5.getUpperLimit());
         assertEquals("Astatine", this.node2.getUpperLimit());
@@ -104,7 +104,7 @@ public class TestPDNameTreeNode
     }
 
     @Test
-    public void testLowerLimit() throws IOException
+    void testLowerLimit() throws IOException
     {
         assertEquals("Actinium", this.node5.getLowerLimit());
         assertEquals("Actinium", this.node2.getLowerLimit());

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNumberTreeNode.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNumberTreeNode.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNumberTreeNode.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/TestPDNumberTreeNode.java Wed Nov 18 16:34:17 2020
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
  * 
  * @author Dominic Tubach
  */
-public class TestPDNumberTreeNode
+class TestPDNumberTreeNode
 {
 
     private PDNumberTreeNode node1;
@@ -145,7 +145,7 @@ public class TestPDNumberTreeNode
     }
     
     @Test
-    public void testGetValue() throws IOException
+    void testGetValue() throws IOException
     {
         assertEquals(new PDTest( 51 ), this.node5.getValue( 4 ));
         assertEquals(new PDTest(70), this.node1.getValue( 9 ));
@@ -156,7 +156,7 @@ public class TestPDNumberTreeNode
     }
 
     @Test
-    public void testUpperLimit() throws IOException
+    void testUpperLimit() throws IOException
     {
         assertEquals(7, (int) this.node5.getUpperLimit());
         assertEquals(7, (int) this.node2.getUpperLimit());
@@ -177,7 +177,7 @@ public class TestPDNumberTreeNode
     }
 
     @Test
-    public void testLowerLimit() throws IOException
+    void testLowerLimit() throws IOException
     {
         assertEquals(1, (int) this.node5.getLowerLimit());
         assertEquals(1, (int) this.node2.getLowerLimit());

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/function/TestPDFunctionType4.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/function/TestPDFunctionType4.java?rev=1883607&r1=1883606&r2=1883607&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/function/TestPDFunctionType4.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/function/TestPDFunctionType4.java Wed Nov 18 16:34:17 2020
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Tests the {@link PDFunctionType4} class.
  */
-public class TestPDFunctionType4
+class TestPDFunctionType4
 {
 
     private PDFunctionType4 createFunction(String function, float[] domain, float[] range)
@@ -57,7 +57,7 @@ public class TestPDFunctionType4
      * @throws Exception if an error occurs
      */
     @Test
-    public void testFunctionSimple() throws Exception
+    void testFunctionSimple() throws Exception
     {
         String functionText = "{ add }";
         //Simply adds the two arguments and returns the result
@@ -90,7 +90,7 @@ public class TestPDFunctionType4
      * @throws Exception if an error occurs
      */
     @Test
-    public void testFunctionArgumentOrder() throws Exception
+    void testFunctionArgumentOrder() throws Exception
     {
         String functionText = "{ pop }";
         // pops an argument (2nd) and returns the next argument (1st)