You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:00:29 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #662: Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats)
alamb opened a new pull request #662:
URL: https://github.com/apache/arrow-rs/pull/662
Built on https://github.com/apache/arrow-rs/pull/643 so draft until that is merged
# Which issue does this PR close?
Resolves https://github.com/apache/arrow-rs/issues/660
# Rationale for this change
FixedLenByteArray columns were writing the wrong type of statistics
# What changes are included in this PR?
Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats)
# Are there any user-facing changes?
FixedLenByteArray statistics are written rather than ByteArray statistics. I am not sure if this is a user visible change however (see description on https://github.com/apache/arrow-rs/pull/661#issue-704674883)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #662: Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #662:
URL: https://github.com/apache/arrow-rs/pull/662#issuecomment-893455716
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#662](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18349ac) into [master](https://codecov.io/gh/apache/arrow-rs/commit/6bf1988852f87da21a163203eec4c83a7b692901?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bf1988) will **decrease** coverage by `0.06%`.
> The diff coverage is `85.39%`.
> :exclamation: Current head 18349ac differs from pull request most recent head 67add39. Consider uploading reports for the commit 67add39 to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #662 +/- ##
==========================================
- Coverage 82.50% 82.43% -0.07%
==========================================
Files 168 168
Lines 47249 47325 +76
==========================================
+ Hits 38984 39014 +30
- Misses 8265 8311 +46
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/column/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3dyaXRlci5ycw==) | `92.81% <85.36%> (-0.49%)` | :arrow_down: |
| [parquet/src/data\_type.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZGF0YV90eXBlLnJz) | `77.29% <85.71%> (+0.75%)` | :arrow_up: |
| [arrow/src/array/transform/boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9ib29sZWFuLnJz) | `76.92% <0.00%> (-7.70%)` | :arrow_down: |
| [arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS91dGlscy5ycw==) | `95.00% <0.00%> (-5.00%)` | :arrow_down: |
| [arrow/src/array/equal\_json.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsX2pzb24ucnM=) | `85.21% <0.00%> (-3.48%)` | :arrow_down: |
| [arrow/src/tensor.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3RlbnNvci5ycw==) | `85.00% <0.00%> (-2.50%)` | :arrow_down: |
| [parquet/src/column/page.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3BhZ2UucnM=) | `97.36% <0.00%> (-1.32%)` | :arrow_down: |
| [arrow/src/array/equal/utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL3V0aWxzLnJz) | `74.00% <0.00%> (-1.00%)` | :arrow_down: |
| [parquet/src/record/api.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvcmVjb3JkL2FwaS5ycw==) | `91.60% <0.00%> (-0.88%)` | :arrow_down: |
| [parquet/src/file/statistics.rs](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZmlsZS9zdGF0aXN0aWNzLnJz) | `93.80% <0.00%> (-0.83%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/arrow-rs/pull/662/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6bf1988...67add39](https://codecov.io/gh/apache/arrow-rs/pull/662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] sunchao merged pull request #662: Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats)
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #662:
URL: https://github.com/apache/arrow-rs/pull/662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org