You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/11 01:08:41 UTC
[GitHub] [druid] vogievetsky opened a new pull request #10741: Web console: fix bad results if there is not native bigint
vogievetsky opened a new pull request #10741:
URL: https://github.com/apache/druid/pull/10741
This PR bumps the version of json-bigint-native to fix a bug where it would throw an error if `BigInt` was not defined (instead of doing a fallback).
This caused the results not to get parsed (due to the code in https://github.com/apache/druid/blob/master/web-console/src/singletons/api.ts#L37) and be returned as a string, which causes this madness:
This is on Safari 13.1 (which does not have `BigInt` yet)
Added a test to make sure there is a graceful fallback to `number`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10741: Web console: fix bad results if there is not native bigint
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10741:
URL: https://github.com/apache/druid/pull/10741#issuecomment-759124141
nice test!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #10741: Web console: fix bad results if there is not native bigint
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #10741:
URL: https://github.com/apache/druid/pull/10741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org