[GitHub] [incubator-tvm] liangfu commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT

[GitBox <gi...@apache.org>]

liangfu commented on a change in pull request #5124: [uTVM][Runtime] Introduce Virtual Memory Allocator to CRT
URL: https://github.com/apache/incubator-tvm/pull/5124#discussion_r398378354
 
 

 ##########
 File path: src/runtime/crt/crt_runtime_api.c
 ##########
 @@ -79,7 +79,7 @@ int TVMModGetFunction(TVMModuleHandle mod,
   if (!strcmp(func_name, "load_params")) {
     *out = &TVMGraphRuntime_LoadParams;
   } else {
-    status -1;
+    status = -1;
 
 Review comment:
   Actually we do have the CRT sources checked by the cpplint, but it failed to catch the case. As the CRT is growing, I think we might need cppcheck to ensure the compliance to MISRA-C rules, since it contains a very nice checker [misra.py](https://github.com/danmar/cppcheck/blob/master/addons/misra.py) .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services