You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/05/10 14:23:00 UTC
[tomcat] branch main updated (957133f838 -> 366bb95af8)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 957133f838 No need to create a nonce cache if you aren't going to create a nonce
new 4a7722a90d Remove meaningless code
new 366bb95af8 Remove meaningless code
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/catalina/core/StandardThreadExecutor.java | 16 ----------------
java/org/apache/catalina/core/mbeans-descriptors.xml | 4 ----
webapps/docs/config/executor.xml | 4 ----
3 files changed, 24 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 02/02: Remove meaningless code
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 366bb95af80b65ce288de094b632546ef3f06839
Author: lihan <ao...@gmail.com>
AuthorDate: Sun May 8 20:13:35 2022 +0800
Remove meaningless code
---
java/org/apache/catalina/core/mbeans-descriptors.xml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/java/org/apache/catalina/core/mbeans-descriptors.xml b/java/org/apache/catalina/core/mbeans-descriptors.xml
index db0d6ca38e..a86207780f 100644
--- a/java/org/apache/catalina/core/mbeans-descriptors.xml
+++ b/java/org/apache/catalina/core/mbeans-descriptors.xml
@@ -1524,10 +1524,6 @@
type="int"
writeable="false" />
- <attribute name="prestartminSpareThreads"
- description="Prestart threads?"
- is="true"
- type="boolean"/>
<attribute name="queueSize"
description="Number of tasks waiting to be processed"
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 01/02: Remove meaningless code
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 4a7722a90dca22c6113907ecb2420cd9fa0a4678
Author: lihan <ao...@gmail.com>
AuthorDate: Sun May 8 19:32:59 2022 +0800
Remove meaningless code
---
.../org/apache/catalina/core/StandardThreadExecutor.java | 16 ----------------
webapps/docs/config/executor.xml | 4 ----
2 files changed, 20 deletions(-)
diff --git a/java/org/apache/catalina/core/StandardThreadExecutor.java b/java/org/apache/catalina/core/StandardThreadExecutor.java
index 2c714efedc..7f926108c8 100644
--- a/java/org/apache/catalina/core/StandardThreadExecutor.java
+++ b/java/org/apache/catalina/core/StandardThreadExecutor.java
@@ -74,11 +74,6 @@ public class StandardThreadExecutor extends LifecycleMBeanBase
*/
protected String name;
- /**
- * prestart threads?
- */
- protected boolean prestartminSpareThreads = false;
-
/**
* The maximum number of elements that can queue up before we reject them
*/
@@ -121,9 +116,6 @@ public class StandardThreadExecutor extends LifecycleMBeanBase
TaskThreadFactory tf = new TaskThreadFactory(namePrefix,daemon,getThreadPriority());
executor = new ThreadPoolExecutor(getMinSpareThreads(), getMaxThreads(), maxIdleTime, TimeUnit.MILLISECONDS,taskqueue, tf);
executor.setThreadRenewalDelay(threadRenewalDelay);
- if (prestartminSpareThreads) {
- executor.prestartAllCoreThreads();
- }
taskqueue.setParent(executor);
setState(LifecycleState.STARTING);
@@ -203,10 +195,6 @@ public class StandardThreadExecutor extends LifecycleMBeanBase
return name;
}
- public boolean isPrestartminSpareThreads() {
-
- return prestartminSpareThreads;
- }
public void setThreadPriority(int threadPriority) {
this.threadPriority = threadPriority;
}
@@ -240,10 +228,6 @@ public class StandardThreadExecutor extends LifecycleMBeanBase
}
}
- public void setPrestartminSpareThreads(boolean prestartminSpareThreads) {
- this.prestartminSpareThreads = prestartminSpareThreads;
- }
-
public void setName(String name) {
this.name = name;
}
diff --git a/webapps/docs/config/executor.xml b/webapps/docs/config/executor.xml
index b896a91587..05b1420b8e 100644
--- a/webapps/docs/config/executor.xml
+++ b/webapps/docs/config/executor.xml
@@ -107,10 +107,6 @@
<p>(int) The maximum number of runnable tasks that can queue up awaiting
execution before we reject them. Default value is <code>Integer.MAX_VALUE</code></p>
</attribute>
- <attribute name="prestartminSpareThreads" required="false">
- <p>(boolean) Whether minSpareThreads should be started when starting the Executor or not,
- the default is <code>false</code></p>
- </attribute>
<attribute name="threadRenewalDelay" required="false">
<p>(long) If a <a href="listeners.html">ThreadLocalLeakPreventionListener</a> is configured,
it will notify this executor about stopped contexts.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org