[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #697: Move All metadata query parser from Client into Server.

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #697: Move All metadata query parser from Client into Server.
URL: https://github.com/apache/incubator-iotdb/pull/697#discussion_r362301279
 
 

 ##########
 File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBMetadataFetchIT.java
 ##########
 @@ -180,11 +176,11 @@ public void databaseMetaDataTest() throws ClassNotFoundException, SQLException {
           .getConnection(Config.IOTDB_URL_PREFIX + "127.0.0.1:6667/", "root", "root");
       databaseMetaData = connection.getMetaData();
 
-      allColumns();
-      device();
-      showTimeseriesPath1();
-      showTimeseriesPath2();
-      showStorageGroup();
+//      allColumns();
+//      device();
+//      showTimeseriesPath1();
+//      showTimeseriesPath2();
+//      showStorageGroup();
 
 Review comment:
   They are used to test the show statements instead of `getColumn()`, you just changed the way of using them and commenting them will make the functionality untested, which should be avoided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services