You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/05/05 17:59:48 UTC
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
philip@tigris.org writes:
> + /** ### comparing URLs, should they be cannonicalized first? */
> + if (! svn_stringbuf_compare (entry->url, url))
> + return
> + svn_error_createf (SVN_ERR_WC_OBSTRUCTED_UPDATE, 0, NULL, pool,
> + "URL '%s' doesn't match existing URL '%s' in '%s'",
> + url->data, entry->url->data, path->data);
> + }
I think there should be no need to canonicalize them -- they should
already be in canonical form. If they're not, that's a bug we'd want
revealed anyway (?)...
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> See http://subversion.tigris.org/issues/show_bug.cgi?id=603
Thanks; I've annotated the issue with this thread.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
Posted by Branko Čibej <br...@xbc.nu>.
Karl Fogel wrote:
>Branko Čibej <br...@xbc.nu> writes:
>
>>>So, should we canonicalize URLs before using them, or just not depend
>>>on them being canonicalized? I lean toward the former, so that
>>>comparisons are reliable. But I have a feeling someone (or somemany)
>>>have thought deeply on this question already, and will have something
>>>unexpected to say...
>>>
>>The same rules apply as for local paths: the client is responsible for
>>utf-8'ing and canonicalizing URLs and paths before passing them off
>>into the SVN APIs. Right now, of course, the client doesn't do
>>that. :-)
>>
>
>That's what I've been thinking too, and it comforts me to hear you
>confirm it.
>
>I'll file an issue about this; it may or may not be related to
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=698
>
>need to investigate more.
>
>-K
>
See http://subversion.tigris.org/issues/show_bug.cgi?id=603
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> >So, should we canonicalize URLs before using them, or just not depend
> >on them being canonicalized? I lean toward the former, so that
> >comparisons are reliable. But I have a feeling someone (or somemany)
> >have thought deeply on this question already, and will have something
> >unexpected to say...
> >
> The same rules apply as for local paths: the client is responsible for
> utf-8'ing and canonicalizing URLs and paths before passing them off
> into the SVN APIs. Right now, of course, the client doesn't do
> that. :-)
That's what I've been thinking too, and it comforts me to hear you
confirm it.
I'll file an issue about this; it may or may not be related to
http://subversion.tigris.org/issues/show_bug.cgi?id=698
need to investigate more.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
Posted by Branko Čibej <br...@xbc.nu>.
Karl Fogel wrote:
>Philip Martin <ph...@codematters.co.uk> writes:
>
>>>I think there should be no need to canonicalize them -- they should
>>>already be in canonical form. If they're not, that's a bug we'd want
>>>revealed anyway (?)...
>>>
>>Hmmm....
>>
>>$ svn co -d ~/wc http://svn.collab.net:81/repos/svn/trunk/tools/dev
>>$ svn co -d ~/wc http://svn.collab.net:81/repos/svn/trunk//tools/dev
>>
>>../svn/subversion/libsvn_wc/adm_files.c:1125
>>svn_error: #21034 : <Obstructed update>
>> URL 'http://svn.collab.net:81/repos/svn/trunk//tools/dev' doesn't match existing URL 'http://svn.collab.net:81/repos/svn/trunk/tools/dev' in '/home/pm/wc'
>>
>
>Urg. Hmmm. Nice experiment :-).
>
>So, should we canonicalize URLs before using them, or just not depend
>on them being canonicalized? I lean toward the former, so that
>comparisons are reliable. But I have a feeling someone (or somemany)
>have thought deeply on this question already, and will have something
>unexpected to say...
>
The same rules apply as for local paths: the client is responsible for
utf-8'ing and canonicalizing URLs and paths before passing them off into
the SVN APIs. Right now, of course, the client doesn't do that. :-)
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Philip Martin <ph...@codematters.co.uk> writes:
> > I think there should be no need to canonicalize them -- they should
> > already be in canonical form. If they're not, that's a bug we'd want
> > revealed anyway (?)...
>
> Hmmm....
>
> $ svn co -d ~/wc http://svn.collab.net:81/repos/svn/trunk/tools/dev
> $ svn co -d ~/wc http://svn.collab.net:81/repos/svn/trunk//tools/dev
>
> ../svn/subversion/libsvn_wc/adm_files.c:1125
> svn_error: #21034 : <Obstructed update>
> URL 'http://svn.collab.net:81/repos/svn/trunk//tools/dev' doesn't match existing URL 'http://svn.collab.net:81/repos/svn/trunk/tools/dev' in '/home/pm/wc'
Urg. Hmmm. Nice experiment :-).
So, should we canonicalize URLs before using them, or just not depend
on them being canonicalized? I lean toward the former, so that
comparisons are reliable. But I have a feeling someone (or somemany)
have thought deeply on this question already, and will have something
unexpected to say...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1877 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline
Posted by Philip Martin <ph...@codematters.co.uk>.
Karl Fogel <kf...@newton.ch.collab.net> writes:
> philip@tigris.org writes:
> > + /** ### comparing URLs, should they be cannonicalized first? */
> > + if (! svn_stringbuf_compare (entry->url, url))
> > + return
> > + svn_error_createf (SVN_ERR_WC_OBSTRUCTED_UPDATE, 0, NULL, pool,
> > + "URL '%s' doesn't match existing URL '%s' in '%s'",
> > + url->data, entry->url->data, path->data);
> > + }
>
> I think there should be no need to canonicalize them -- they should
> already be in canonical form. If they're not, that's a bug we'd want
> revealed anyway (?)...
Hmmm....
$ svn co -d ~/wc http://svn.collab.net:81/repos/svn/trunk/tools/dev
$ svn co -d ~/wc http://svn.collab.net:81/repos/svn/trunk//tools/dev
../svn/subversion/libsvn_wc/adm_files.c:1125
svn_error: #21034 : <Obstructed update>
URL 'http://svn.collab.net:81/repos/svn/trunk//tools/dev' doesn't match existing URL 'http://svn.collab.net:81/repos/svn/trunk/tools/dev' in '/home/pm/wc'
--
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org