You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "kanha-gupta (via GitHub)" <gi...@apache.org> on 2023/03/05 17:38:34 UTC
[GitHub] [shardingsphere] kanha-gupta opened a new pull request, #24470: support for Repeat function
kanha-gupta opened a new pull request, #24470:
URL: https://github.com/apache/shardingsphere/pull/24470
Fixes #24398 .
Changes proposed in this pull request:
support for REPEAT function
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24470: support for Repeat function
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24470:
URL: https://github.com/apache/shardingsphere/pull/24470#issuecomment-1455162632
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24470](https://codecov.io/gh/apache/shardingsphere/pull/24470?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ec4319) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5ed5a7af542c926c4ff9cf29deb877b85a784f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ed5a7a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2ec4319 differs from pull request most recent head 049c349. Consider uploading reports for the commit 049c349 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24470 +/- ##
=========================================
Coverage 49.93% 49.93%
Complexity 1584 1584
=========================================
Files 3257 3257
Lines 53586 53586
Branches 9869 9869
=========================================
Hits 26758 26758
Misses 24429 24429
Partials 2399 2399
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on pull request #24470: support for Repeat function
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on PR #24470:
URL: https://github.com/apache/shardingsphere/pull/24470#issuecomment-1455155538
@RaigorJiang @strongduanmu Please guide if the approach is fine ? if yes then i'll proceed with adding support for others too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #24470: support for Repeat function
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24470:
URL: https://github.com/apache/shardingsphere/pull/24470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #24470: support for Repeat function
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #24470:
URL: https://github.com/apache/shardingsphere/pull/24470#discussion_r1125874109
##########
test/it/parser/src/main/resources/case/dml/select-expression.xml:
##########
@@ -2089,6 +2089,23 @@
</projections>
</select>
+ <select sql-case-id="select_with_repeat_function">
+ <projections start-index="7" stop-index="25">
Review Comment:
Please keep the same indent as the other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org