You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:00:35 UTC

[GitHub] [shenyu] leopardrota commented on a diff in pull request #3838: [ISSUE #3805] Add `ShenyuService` and `ShenyuDubboService` annotations for shenyu-client-apache-dubbo

leopardrota commented on code in PR #3838:
URL: https://github.com/apache/shenyu/pull/3838#discussion_r985434758


##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboMultiParamServiceImpl.java:
##########
@@ -32,7 +32,7 @@
 /**
  * The type Dubbo multi param service.
  */
-@DubboService
+@ShenyuDubboService("demo")

Review Comment:
   Why did not this be rollbacked?  It seems that Dubbo only resolves the direct annotation, not composite annotation. (#4031)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org