You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/15 09:25:29 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

rkhachatryan opened a new pull request #19096:
URL: https://github.com/apache/flink/pull/19096


   ## What is the purpose of the change
   
   Key group is logged so that state changes can be re-distributed or shuffled.
   It is currently obtained from keyContext for remove() operations.
   However, keyContext is not updated when dequeing or processing time timers.
   
   This causes re-scaling to fail if:
   1. there is materialized state
   1. there are remove operations
   1. wrong key group was recorded for those operations
   1. those groups fall into a different backend as a result of re-scaling
   
   ## Verifying this change
   - `ChangelogRescalingITCase`
   - Verified manually on a standalone cluster
   - 
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19096:
URL: https://github.com/apache/flink/pull/19096#issuecomment-1067840283


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33100",
       "triggerID" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fe18319030d2216e991e58d8ba7b940010a6714",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2fe18319030d2216e991e58d8ba7b940010a6714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5331dae21376c5da2b0e1d2a841f9e3a596083ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33100) 
   * 2fe18319030d2216e991e58d8ba7b940010a6714 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19096:
URL: https://github.com/apache/flink/pull/19096#issuecomment-1067840283


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33100",
       "triggerID" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fe18319030d2216e991e58d8ba7b940010a6714",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33106",
       "triggerID" : "2fe18319030d2216e991e58d8ba7b940010a6714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2fe18319030d2216e991e58d8ba7b940010a6714 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19096:
URL: https://github.com/apache/flink/pull/19096#issuecomment-1067840283


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33100",
       "triggerID" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fe18319030d2216e991e58d8ba7b940010a6714",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33106",
       "triggerID" : "2fe18319030d2216e991e58d8ba7b940010a6714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5331dae21376c5da2b0e1d2a841f9e3a596083ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33100) 
   * 2fe18319030d2216e991e58d8ba7b940010a6714 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33106) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19096:
URL: https://github.com/apache/flink/pull/19096#issuecomment-1068243177


   Thanks for the review!
   Merged into 1.15 as e31c1b0f88cbcd3f3a720948123b262fc21e4cd5 and into master as 092647cb3db6dcdf43fbf4a04b9f6cd5a95bee79.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19096:
URL: https://github.com/apache/flink/pull/19096#issuecomment-1067840283


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5331dae21376c5da2b0e1d2a841f9e3a596083ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5331dae21376c5da2b0e1d2a841f9e3a596083ad UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan merged pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #19096:
URL: https://github.com/apache/flink/pull/19096


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on a change in pull request #19096: [FLINK-26063][runtime] Set current key before polling next PQ element

Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #19096:
URL: https://github.com/apache/flink/pull/19096#discussion_r826764473



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/InternalPriorityQueue.java
##########
@@ -77,6 +80,9 @@
     /**
      * Check if the set contains any elements.
      *
+     * <p>NOTE: Correct key (i.e. the key of the polled element) must be set on KeyContext before
+     * calling this method.

Review comment:
       I don't think we need to add such docs to `#isEmpty()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org