You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HuaHuaY (via GitHub)" <gi...@apache.org> on 2025/09/28 11:28:21 UTC
[PR] GH-47664: [C++][Parquet] add num_rows_ before each call to RowGroupWriter::Close in FileSerializer [arrow]
HuaHuaY opened a new pull request, #47665:
URL: https://github.com/apache/arrow/pull/47665
### Rationale for this change
Fix wrong result of `num_rows()` method in `FileSerializer`.
### What changes are included in this PR?
1. add `num_rows_` before each call to `RowGroupWriter::Close` in `FileSerializer`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Now `num_rows_` will return the corrent result which is the number of rows in the yet started RowGroups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47664: [C++][Parquet] add num_rows_ before each call to RowGroupWriter::Close in FileSerializer [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47665:
URL: https://github.com/apache/arrow/pull/47665#issuecomment-3342991806
:warning: GitHub issue #47664 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47664: [C++][Parquet] add num_rows_ before each call to RowGroupWriter::Close in FileSerializer [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #47665:
URL: https://github.com/apache/arrow/pull/47665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47664: [C++][Parquet] add num_rows_ before each call to RowGroupWriter::Close in FileSerializer [arrow]
Posted by "HuaHuaY (via GitHub)" <gi...@apache.org>.
HuaHuaY commented on PR #47665:
URL: https://github.com/apache/arrow/pull/47665#issuecomment-3343001505
@pitrou @wgtmac @mapleFU Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47664: [C++][Parquet] add num_rows_ before each call to RowGroupWriter::Close in FileSerializer [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47665:
URL: https://github.com/apache/arrow/pull/47665#issuecomment-3387288178
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5750e2932fc26c27be92fe9262f6b128a513abca.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `amd64-m5-4xlarge-linux` at [2025-10-09 19:14:47Z](https://conbench.ursa.dev/compare/runs/dfbf18f008eb4785822a376fcaa3f358...84e59f4843954caea0707aca5abe9892/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-18, scale_factor=10](https://conbench.ursa.dev/compare/benchmarks/068e7b48259f755380009502c19ec5da...068e8098335c7cf680001f69a400c389)
The [full Conbench report](https://github.com/apache/arrow/runs/52389243271) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org