[GitHub] [camel-k] astefanutti commented on pull request #1660: [test] Create integration test for exposing metrics to prometheus

[GitBox <gi...@apache.org>]

astefanutti commented on pull request #1660:
URL: https://github.com/apache/camel-k/pull/1660#issuecomment-674766696


   > @astefanutti Shouldn't i use oc client instead of kubectl ? (i'm not sure if the Prometheus monitoring is also in plain Kubernetes). If so, should i also change the way how the tests are triggered by the automation ? Because they should run only on openshift then (now they run as part of kubernetes github action).
   
   The Prometheus trait also works with vanilla Kubernetes, so it should ideally be tested also. The assertions will probably have to be different, as for vanilla Kubernetes Thanos is not a pre-requisite.
   
   It is fine to use `kubectl` even on OpenShift. Both `oc` and `kubectl` can be used interchangeably (except for `oc` specific commands), but one may chose to use `oc` for OpenShift environment for consistency purpose.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org