You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/05 06:49:11 UTC
[GitHub] zeppelin pull request #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-cha...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1974
[ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change when select value changed.
### What is this PR for?
Run paragraph on ng-change when select value changed.
### What type of PR is it?
[Bug Fix | Hot Fix]
### What is the Jira issue?
* [ZEPPELIN-2000](https://issues.apache.org/jira/browse/ZEPPELIN-2000)
### How should this be tested?
- Go to Zeppelin Tutorial/Basic Features (Spark) notebook
- Change selected value from married to single in 5th paragraph and hit enter.
- Change view mode to report and check step 2.
- See if paragraph runs
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin hotfix/ZEPPELIN-2000
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1974
----
commit 6e34366e8c697da8e24b350198df67181e39c4da
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-05T06:42:19Z
Run paragraph ng-change when select value changed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1974
hmm.. interesting, so it's by design then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1974
fyi, this behavior change is introduced in #1647.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1974
@minahlee, @jongyoul, @felixcheung Please help review this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1974
I think Zeppelin has been back and forth couple of times with this behavior.
I agree current behavior (require user run paragraph after dynamic form change) can confuse user because
* Previous version does not require run paragraph after dynamic form change
* After dynamic form change, zeppelin just does nothing. i.e. zeppelin does not kindly guide user run paragraph manually.
If we want to resolve issue https://issues.apache.org/jira/browse/ZEPPELIN-1013 in 0.7.0, then we can keep current behavior and add some visual notification after dynamic form change. (e.g. such as blink or bounce 'run' button when user change dynamic form)
Or we can revert change and try resolve ZEPPELIN-1013 in 0.8.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-cha...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/1974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1974
looks good. I guess the difference between this and PR #1932 is
> Change selected value from married to single in 5th paragraph ~~and hit enter.~~
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1974
I agree that this can be confusing for the long time user, but I think this is not a blocking issue since user can still run the paragraph. I believe we can handle this issue in next maintenance release.
I just created ticket [ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060) and set the fixed version to 0.7.1.
Release note mentioned this change [here](https://github.com/apache/zeppelin/pull/1972/files#diff-7c8381692ac3b26e7bc352880cc1126eR116).
@prabhjyotsingh Shall we close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1974
Sorry I didn't find this earlier or reviewed the fixes more closely.
I know everyone has been putting a lot of effort in rolling out this release, so I don't want to block it.
I do think it could be very confusing for long time user with this behavior change.
So perhaps we should do either what I proposed https://github.com/apache/zeppelin/pull/1974#issuecomment-277502448 or you suggested https://github.com/apache/zeppelin/pull/1974#issuecomment-277502684 with visual clue.
But I'm ok with just documenting this in release note and move on to 0.7+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1974
Yes, sure I'll close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---