You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/22 03:35:43 UTC

[GitHub] [druid] viongpanzi commented on issue #9722: Optimize FileWriteOutBytes to avoid high system cpu usage

viongpanzi commented on issue #9722:
URL: https://github.com/apache/druid/pull/9722#issuecomment-617529093


   > Thanks for the fix and the benchmarks! I haven't read through the benchmark changes but it makes sense why this change would have a big perf benefit.
   > 
   > The only thought I had here is - how do we make sure that writeOutBytes is always in sync. I couldn't find any unit tests for FileWriteOutBytes, but is it covered by some other test?
   
   Good question！There are some unit tests in `WriteOutBytesTest.java`, so I do not add new test cases. I'll try to add more test cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org