You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2019/12/15 14:10:07 UTC

Re: [httpcomponents-client] 06/12: Use language-agnotic Locale.ROOT

Michael:

There is another use of Locale.US
in org.apache.hc.client5.http.impl.auth.DigestScheme.createDigestResponse(HttpRequest)

Gary

On Sun, Dec 15, 2019 at 5:49 AM <mi...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> michaelo pushed a commit to branch consistency
> in repository
> https://gitbox.apache.org/repos/asf/httpcomponents-client.git
>
> commit 846a25561c70148ae89a1ea4ae49bb7e9473d68f
> Author: Michael Osipov <mi...@apache.org>
> AuthorDate: Sun Dec 15 10:58:41 2019 +0100
>
>     Use language-agnotic Locale.ROOT
> ---
>  .../java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java    |
> 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
> b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
> index cfa28ac..80fdb6b 100644
> ---
> a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
> +++
> b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
> @@ -65,7 +65,7 @@ class BasicIdGenerator {
>          final int rndnum = this.rnd.nextInt();
>          buffer.append(System.currentTimeMillis());
>          buffer.append('.');
> -        final Formatter formatter = new Formatter(buffer, Locale.US);
> +        final Formatter formatter = new Formatter(buffer, Locale.ROOT);
>          formatter.format("%1$016x-%2$08x", Long.valueOf(this.count),
> Integer.valueOf(rndnum));
>          formatter.close();
>          buffer.append('.');
>
>

Re: [httpcomponents-client] 06/12: Use language-agnotic Locale.ROOT

Posted by Michael Osipov <mi...@apache.org>.
Am 2019-12-15 um 15:10 schrieb Gary Gregory:
> Michael:
> 
> There is another use of Locale.US
> in org.apache.hc.client5.http.impl.auth.DigestScheme.createDigestResponse(HttpRequest)

Fixed, thanks!

> On Sun, Dec 15, 2019 at 5:49 AM <mi...@apache.org> wrote:
> 
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> michaelo pushed a commit to branch consistency
>> in repository
>> https://gitbox.apache.org/repos/asf/httpcomponents-client.git
>>
>> commit 846a25561c70148ae89a1ea4ae49bb7e9473d68f
>> Author: Michael Osipov <mi...@apache.org>
>> AuthorDate: Sun Dec 15 10:58:41 2019 +0100
>>
>>      Use language-agnotic Locale.ROOT
>> ---
>>   .../java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java    |
>> 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
>> b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
>> index cfa28ac..80fdb6b 100644
>> ---
>> a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
>> +++
>> b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicIdGenerator.java
>> @@ -65,7 +65,7 @@ class BasicIdGenerator {
>>           final int rndnum = this.rnd.nextInt();
>>           buffer.append(System.currentTimeMillis());
>>           buffer.append('.');
>> -        final Formatter formatter = new Formatter(buffer, Locale.US);
>> +        final Formatter formatter = new Formatter(buffer, Locale.ROOT);
>>           formatter.format("%1$016x-%2$08x", Long.valueOf(this.count),
>> Integer.valueOf(rndnum));
>>           formatter.close();
>>           buffer.append('.');
>>
>>
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org