You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/10/12 11:50:06 UTC
Re: [Apache Bloodhound] #229: Email change updates should show
diffs, not full text
#229: Email change updates should show diffs, not full text
--------------------------+---------------------------------
Reporter: jdreimann | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: email notifications
--------------------------+---------------------------------
Changes (by jdreimann):
* keywords: => email notifications
Old description:
> ,, ... via ''Bloodhound'' quick create ticket dialog,,
New description:
Currently these emails show the full text before the change, and the full
text after the change.
As an example,
[https://issues.apache.org/bloodhound/ticket/115?action=diff&version=2
this change] triggered [http://mail-archives.apache.org/mod_mbox
/incubator-bloodhound-
commits/201210.mbox/%3C070.12e315d1fb01dea5055b33eda063802b%40incubator.apache.org%3E
this email]. My suggestion is that the email should contain only the diff
information.
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/229#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Gary Martin <ga...@wandisco.com>.
I don't think that we need a quick decision on this. Unless anyone can
point it out as folly, I am still very much in favour of the full text
diff.
Cheers,
Gary
On 15/10/12 21:34, Joe Dreimann wrote:
> I read the same and assumed you knew more than the ticket stated.
>
> Anyway, I've got no issue with pulling ahead of them.
>
> - Joe
>
> ________________________
> @jdreimann - Twitter
> Sent from my phone
>
> On 15 Oct 2012, at 21:17, Ryan Ollos <ry...@wandisco.com> wrote:
>
>> On Mon, Oct 15, 2012 at 4:24 AM, Ryan Ollos <ry...@wandisco.com> wrote:
>>
>>> [...]
>>>
>>> * JIRA didn't seem to be doing any better than this until very recently:
>>> https://jira.atlassian.com/browse/JRA-25667
>> On second look, they may not have improved this at all. I read that ticket
>> very quickly and assumed that Status: Resolved, Resolution: Answered meant
>> that there was a fix. However, near the bottom of the ticket, they state: "We
>> are not currently looking at making improvements in this area in the near
>> future."
>>
>>
>> On Mon, Oct 15, 2012 at 7:35 AM, Olemis Lang <ol...@gmail.com> wrote:
>>
>>> [...]
>>>
>>> I was actually thinking in first place of replacing old desc with diff
>>> and keeping new desc . The same actually for custom text fields .
>>
>> I don't feel that strongly about my stated preference. I see either (or
>> any) approach as being better than what is done now, which for a long time
>> I've found to be an undesirable feature of Trac notifications.
>>
>> On a related note, I'm trying to get development ramped back up on
>> AnnouncerPlugin, with the hope that it will be a viable alternative to the
>> core Trac notification system in the near future. It needs a few major
>> fixes at the moment for Trac 0.12+ issues.
--
Gary Martin
gary.martin@wandisco.com
gjm@apache.org
Re: [Apache Bloodhound] #229: Email change updates should show diffs, not full text
Posted by Joe Dreimann <jo...@wandisco.com>.
I read the same and assumed you knew more than the ticket stated.
Anyway, I've got no issue with pulling ahead of them.
- Joe
________________________
@jdreimann - Twitter
Sent from my phone
On 15 Oct 2012, at 21:17, Ryan Ollos <ry...@wandisco.com> wrote:
> On Mon, Oct 15, 2012 at 4:24 AM, Ryan Ollos <ry...@wandisco.com> wrote:
>
>> [...]
>>
>> * JIRA didn't seem to be doing any better than this until very recently:
>> https://jira.atlassian.com/browse/JRA-25667
>
> On second look, they may not have improved this at all. I read that ticket
> very quickly and assumed that Status: Resolved, Resolution: Answered meant
> that there was a fix. However, near the bottom of the ticket, they state: "We
> are not currently looking at making improvements in this area in the near
> future."
>
>
> On Mon, Oct 15, 2012 at 7:35 AM, Olemis Lang <ol...@gmail.com> wrote:
>
>> [...]
>>
>> I was actually thinking in first place of replacing old desc with diff
>> and keeping new desc . The same actually for custom text fields .
>
>
> I don't feel that strongly about my stated preference. I see either (or
> any) approach as being better than what is done now, which for a long time
> I've found to be an undesirable feature of Trac notifications.
>
> On a related note, I'm trying to get development ramped back up on
> AnnouncerPlugin, with the hope that it will be a viable alternative to the
> core Trac notification system in the near future. It needs a few major
> fixes at the moment for Trac 0.12+ issues.
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Ryan Ollos <ry...@wandisco.com>.
On Mon, Oct 15, 2012 at 4:24 AM, Ryan Ollos <ry...@wandisco.com> wrote:
> [...]
>
> * JIRA didn't seem to be doing any better than this until very recently:
> https://jira.atlassian.com/browse/JRA-25667
>
On second look, they may not have improved this at all. I read that ticket
very quickly and assumed that Status: Resolved, Resolution: Answered meant
that there was a fix. However, near the bottom of the ticket, they state: "We
are not currently looking at making improvements in this area in the near
future."
On Mon, Oct 15, 2012 at 7:35 AM, Olemis Lang <ol...@gmail.com> wrote:
> [...]
>
> I was actually thinking in first place of replacing old desc with diff
> and keeping new desc . The same actually for custom text fields .
I don't feel that strongly about my stated preference. I see either (or
any) approach as being better than what is done now, which for a long time
I've found to be an undesirable feature of Trac notifications.
On a related note, I'm trying to get development ramped back up on
AnnouncerPlugin, with the hope that it will be a viable alternative to the
core Trac notification system in the near future. It needs a few major
fixes at the moment for Trac 0.12+ issues.
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Olemis Lang <ol...@gmail.com>.
On 10/15/12, Ryan Ollos <ry...@wandisco.com> wrote:
> I like the approach of showing the full text with the diff embedded.
>
> Two items of interest
> * JIRA didn't seem to be doing any better than this until very recently:
> https://jira.atlassian.com/browse/JRA-25667
> * I would have expected the AnnouncerPlugin to do a better job at this
> since it formats messages in HTML, but it only seems to present a plain
> text diff with a limited number of surrounding lines (
> https://trac-hacks.org/ticket/10485).
>
I was actually thinking in first place of replacing old desc with diff
and keeping new desc . The same actually for custom text fields .
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Ryan Ollos <ry...@wandisco.com>.
I like the approach of showing the full text with the diff embedded.
Two items of interest
* JIRA didn't seem to be doing any better than this until very recently:
https://jira.atlassian.com/browse/JRA-25667
* I would have expected the AnnouncerPlugin to do a better job at this
since it formats messages in HTML, but it only seems to present a plain
text diff with a limited number of surrounding lines (
https://trac-hacks.org/ticket/10485).
[image: Inline image 2]
On Mon, Oct 15, 2012 at 3:30 AM, Gary Martin <ga...@wandisco.com>wrote:
> Well, you could choose to show a diff with the full text shown. Not quite
> the same thing as the clean text of course..
>
> Cheers,
> Gary
>
>
> On 15/10/12 09:50, Peter Koželj wrote:
>
>> +1 for the diff, but not sure we should completely remove the clean text
>> also.
>>
>> Peter
>>
>> On Sat, Oct 13, 2012 at 1:43 AM, Olemis Lang <ol...@gmail.com> wrote:
>>
>> fwiw +1
>>> It's really hard to figure out what part of description and other text
>>> fields changed .
>>>
>>> On 10/12/12, Apache Bloodhound <bl...@incubator.apache.org>
>>> >
>>> wrote:
>>>
>>>> #229: Email change updates should show diffs, not full text
>>>> --------------------------+---**------------------------------
>>>> Reporter: jdreimann | Owner: nobody
>>>> Type: enhancement | Status: new
>>>> Priority: major | Milestone:
>>>> Component: plugins | Version:
>>>> Resolution: | Keywords: email notifications
>>>> --------------------------+---**------------------------------
>>>> Changes (by jdreimann):
>>>>
>>>> * keywords: => email notifications
>>>>
>>>>
>>>> Old description:
>>>>
>>>> ,, ... via ''Bloodhound'' quick create ticket dialog,,
>>>>>
>>>> New description:
>>>>
>>>> Currently these emails show the full text before the change, and the
>>>>
>>> full
>>>
>>>> text after the change.
>>>> As an example,
>>>> [https://issues.apache.org/**bloodhound/ticket/115?action=**
>>>> diff&version=2<https://issues.apache.org/bloodhound/ticket/115?action=diff&version=2>
>>>> this change] triggered [http://mail-archives.apache.**org/mod_mbox<http://mail-archives.apache.org/mod_mbox>
>>>> /incubator-bloodhound-
>>>> commits/201210.mbox/%3C070.**12e315d1fb01dea5055b33eda06380**2b%
>>>>
>>> 40incubator.apache.org%3E
>>>
>>>> this email]. My suggestion is that the email should contain only the
>>>>
>>> diff
>>>
>>>> information.
>>>>
>>>> --
>>>>
>>>> --
>>>> Ticket URL: <https://issues.apache.org/**bloodhound/ticket/229#comment:
>>>> **1 <https://issues.apache.org/bloodhound/ticket/229#comment:1>>
>>>> Apache Bloodhound <https://issues.apache.org/**bloodhound/<https://issues.apache.org/bloodhound/>
>>>> >
>>>> The Apache Bloodhound (incubating) issue tracker
>>>>
>>>>
>>> --
>>> Regards,
>>>
>>> Olemis.
>>>
>>> Blog ES: http://simelo-es.blogspot.com/
>>> Blog EN: http://simelo-en.blogspot.com/
>>>
>>> Featured article:
>>>
>>>
>
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Gary Martin <ga...@wandisco.com>.
Well, you could choose to show a diff with the full text shown. Not
quite the same thing as the clean text of course..
Cheers,
Gary
On 15/10/12 09:50, Peter Koželj wrote:
> +1 for the diff, but not sure we should completely remove the clean text
> also.
>
> Peter
>
> On Sat, Oct 13, 2012 at 1:43 AM, Olemis Lang <ol...@gmail.com> wrote:
>
>> fwiw +1
>> It's really hard to figure out what part of description and other text
>> fields changed .
>>
>> On 10/12/12, Apache Bloodhound <bl...@incubator.apache.org>
>> wrote:
>>> #229: Email change updates should show diffs, not full text
>>> --------------------------+---------------------------------
>>> Reporter: jdreimann | Owner: nobody
>>> Type: enhancement | Status: new
>>> Priority: major | Milestone:
>>> Component: plugins | Version:
>>> Resolution: | Keywords: email notifications
>>> --------------------------+---------------------------------
>>> Changes (by jdreimann):
>>>
>>> * keywords: => email notifications
>>>
>>>
>>> Old description:
>>>
>>>> ,, ... via ''Bloodhound'' quick create ticket dialog,,
>>> New description:
>>>
>>> Currently these emails show the full text before the change, and the
>> full
>>> text after the change.
>>> As an example,
>>> [https://issues.apache.org/bloodhound/ticket/115?action=diff&version=2
>>> this change] triggered [http://mail-archives.apache.org/mod_mbox
>>> /incubator-bloodhound-
>>> commits/201210.mbox/%3C070.12e315d1fb01dea5055b33eda063802b%
>> 40incubator.apache.org%3E
>>> this email]. My suggestion is that the email should contain only the
>> diff
>>> information.
>>>
>>> --
>>>
>>> --
>>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/229#comment:1>
>>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>>> The Apache Bloodhound (incubating) issue tracker
>>>
>>
>> --
>> Regards,
>>
>> Olemis.
>>
>> Blog ES: http://simelo-es.blogspot.com/
>> Blog EN: http://simelo-en.blogspot.com/
>>
>> Featured article:
>>
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Peter Koželj <pe...@digiverse.si>.
+1 for the diff, but not sure we should completely remove the clean text
also.
Peter
On Sat, Oct 13, 2012 at 1:43 AM, Olemis Lang <ol...@gmail.com> wrote:
> fwiw +1
> It's really hard to figure out what part of description and other text
> fields changed .
>
> On 10/12/12, Apache Bloodhound <bl...@incubator.apache.org>
> wrote:
> > #229: Email change updates should show diffs, not full text
> > --------------------------+---------------------------------
> > Reporter: jdreimann | Owner: nobody
> > Type: enhancement | Status: new
> > Priority: major | Milestone:
> > Component: plugins | Version:
> > Resolution: | Keywords: email notifications
> > --------------------------+---------------------------------
> > Changes (by jdreimann):
> >
> > * keywords: => email notifications
> >
> >
> > Old description:
> >
> >> ,, ... via ''Bloodhound'' quick create ticket dialog,,
> >
> > New description:
> >
> > Currently these emails show the full text before the change, and the
> full
> > text after the change.
> > As an example,
> > [https://issues.apache.org/bloodhound/ticket/115?action=diff&version=2
> > this change] triggered [http://mail-archives.apache.org/mod_mbox
> > /incubator-bloodhound-
> > commits/201210.mbox/%3C070.12e315d1fb01dea5055b33eda063802b%
> 40incubator.apache.org%3E
> > this email]. My suggestion is that the email should contain only the
> diff
> > information.
> >
> > --
> >
> > --
> > Ticket URL: <https://issues.apache.org/bloodhound/ticket/229#comment:1>
> > Apache Bloodhound <https://issues.apache.org/bloodhound/>
> > The Apache Bloodhound (incubating) issue tracker
> >
>
>
> --
> Regards,
>
> Olemis.
>
> Blog ES: http://simelo-es.blogspot.com/
> Blog EN: http://simelo-en.blogspot.com/
>
> Featured article:
>
Re: [Apache Bloodhound] #229: Email change updates should show diffs,
not full text
Posted by Olemis Lang <ol...@gmail.com>.
fwiw +1
It's really hard to figure out what part of description and other text
fields changed .
On 10/12/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #229: Email change updates should show diffs, not full text
> --------------------------+---------------------------------
> Reporter: jdreimann | Owner: nobody
> Type: enhancement | Status: new
> Priority: major | Milestone:
> Component: plugins | Version:
> Resolution: | Keywords: email notifications
> --------------------------+---------------------------------
> Changes (by jdreimann):
>
> * keywords: => email notifications
>
>
> Old description:
>
>> ,, ... via ''Bloodhound'' quick create ticket dialog,,
>
> New description:
>
> Currently these emails show the full text before the change, and the full
> text after the change.
> As an example,
> [https://issues.apache.org/bloodhound/ticket/115?action=diff&version=2
> this change] triggered [http://mail-archives.apache.org/mod_mbox
> /incubator-bloodhound-
> commits/201210.mbox/%3C070.12e315d1fb01dea5055b33eda063802b%40incubator.apache.org%3E
> this email]. My suggestion is that the email should contain only the diff
> information.
>
> --
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/229#comment:1>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article: