[GitHub] [ignite] korlov42 commented on a change in pull request #8518: IGNITE-13772 Calcite, NPE on join.

[GitBox <gi...@apache.org>]

korlov42 commented on a change in pull request #8518:
URL: https://github.com/apache/ignite/pull/8518#discussion_r540033343



##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java
##########
@@ -69,6 +81,22 @@
     /** */
     protected int nodesCnt = 3;
 
+    /** */
+    @Parameterized.Parameters(name = "Execution direction = {0}")
+    public static List<Object[]> parameters() {
+        ArrayList<Object[]> params = new ArrayList<>();
+
+        params.add(new Object[]{true});
+        params.add(new Object[]{false});
+        params.add(new Object[]{null});
+
+        return params;
+    }
+
+    /** Execution direction. */
+    @Parameterized.Parameter
+    public static Boolean execDir;

Review comment:
       @zstan please see my suggestion here: https://github.com/gridgain/apache-ignite/pull/259.
   
   Also introducing params in the abstract class breaks ContinuousExecutionTest




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org