[GitHub] [kafka] ableegoldman commented on a diff in pull request #12935: KAFKA-14432: RocksDBStore relies on finalizers to not leak memory

[GitBox <gi...@apache.org>]

ableegoldman commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1042855507


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -526,6 +521,9 @@ public synchronized void close() {
         fOptions.close();
         filter.close();
         cache.close();
+        if (statistics != null) {
+            statistics.close();
+        }
 

Review Comment:
   > The user still needs to close the statistics he provided
   
   We should add this to the docs then -- users forget to close things all the time, especially if we don't explicitly call out common objects that will need this. Can you file a followup ticket for this? Specifically we should definitely mention it in the rocksdb section of the Memory Management docs, but we also give an example RocksDBConfigSetter in the configuration docs where we might want to include this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org