You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2007/07/08 16:11:56 UTC
svn commit: r554371 -
/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
Author: dennisl
Date: Sun Jul 8 07:11:55 2007
New Revision: 554371
URL: http://svn.apache.org/viewvc?view=rev&rev=554371
Log:
o Make sure that we don't get double '&' in the url.
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java?view=diff&rev=554371&r1=554370&r2=554371
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java Sun Jul 8 07:11:55 2007
@@ -99,11 +99,6 @@
// If the user has defined a filter - use that
if ( ( this.filter != null ) && ( this.filter.length() > 0 ) )
{
- if ( this.filter.charAt( 0 ) == '&' )
- {
- return this.filter.substring( 1 );
- }
-
return this.filter;
}
@@ -237,8 +232,12 @@
fullURL += "&fixfor=" + getFixFor();
}
- // @todo We can get a double && here if createFilter starts with an &
- fullURL += "&" + createFilter();
+ String createdFilter = createFilter();
+ if ( createdFilter.charAt( 0 ) != '&' )
+ {
+ fullURL += "&";
+ }
+ fullURL += createdFilter;
fullURL += ( "&tempMax=" + nbEntriesMax + "&reset=true&decorator=none" );