You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/07/12 06:32:07 UTC

[GitHub] zeppelin pull request #3065: ZEPPELIN-3617. Allow to specify saving resource...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/3065

    ZEPPELIN-3617. Allow to specify saving resourceName as paragraph property

    ### What is this PR for?
    This is allow user to specify resourceName when they want to save the paragraph result into ResourcePool. Before this PR, user don't have control on what name of the saving resource name. It is associated with noteId and paragraphId, but this is not a good solution. Because when you clone the note, noteId will be changed, and you have to change the noteId in code as well. This PR is trying to allow user to set resource Name for the saving paragraph result. 
    
    
    ### What type of PR is it?
    [ Feature |g]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3617
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3617

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3065.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3065
    
----
commit 4bbff1ff2adbc2a3fce299b4d5143fa0f1213471
Author: Jeff Zhang <zj...@...>
Date:   2018-07-12T06:28:02Z

    ZEPPELIN-3617. Allow to specify saving resourceName as paragraph property

----


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    @zjffdu WDYT?


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    @zjffdu Our team do not use actively ResourcePool. We only plan to use.


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    This will also make it possible to access paragraph results easily using the z-variable interpolation feature of various interpreters. So a simple command like `%sh echo {population-table}` will retrieve and display a previously saved (population-table) result (if interpolation is enabled for shell).
    
    But a crafty user will be able to disrupt https://issues.apache.org/jira/browse/ZEPPELIN-3596 by using a resourceName compatible with ZEPPELIN-3596's syntax for {...}
    



---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    @zjffdu First version with ResourcePool was released a month ago (thanks to you ;) )
    Now is good moment to decide future limitations.


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    @mebelousov  This is related with ZEPPELIN-3545, feel free to try this PR and provide comments. 


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    @mebelousov Do you mean you have already used this feature in your company a month ago ?


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    @zjffdu Nice!
    How about adding to ResourcePool only if resourceName specified in paragraph properties?


---

[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3065
  
    Sorry for late response @mebelousov , this is what I planed to do before. The reason I didn't remove this piece of code https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java#L653 is because I am not sure how many use this approach, I just don't want to break users's existing code. But if no one use it, I would sure prefer to add to ResourcePool only if resourceName specified in paragraph properties


---