You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/02 18:52:55 UTC
Review Request 62729: Removed `LIBNAME_VERSION` from `External.cmake`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62729/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, and Joseph Wu.
Bugs: MESOS-8034
https://issues.apache.org/jira/browse/MESOS-8034
Repository: mesos
Description
-------
This variable was superfluous as it is always given as an argument to
`EXTERNAL`, and moreover, the variable of the same name is, in practice,
always set in our `Versions.cmake` file. So `EXTERNAL` was pointlessly
overwriting the variable with the same data.
Diffs
-----
3rdparty/cmake/External.cmake 5bc51bd3822677040ab03edd576c876b74bd8afc
Diff: https://reviews.apache.org/r/62729/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 62729: Removed `LIBNAME_VERSION` from
`External.cmake`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62729/#review186887
-----------------------------------------------------------
Ship it!
3rdparty/cmake/External.cmake
Lines 55-61 (original), 51-57 (patched)
<https://reviews.apache.org/r/62729/#comment263765>
Since we're cleaning this code up, no need to repeat the example comments, as they are already present in the function description.
- Joseph Wu
On Oct. 2, 2017, 11:52 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62729/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:52 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-8034
> https://issues.apache.org/jira/browse/MESOS-8034
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This variable was superfluous as it is always given as an argument to
> `EXTERNAL`, and moreover, the variable of the same name is, in practice,
> always set in our `Versions.cmake` file. So `EXTERNAL` was pointlessly
> overwriting the variable with the same data.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/External.cmake 5bc51bd3822677040ab03edd576c876b74bd8afc
>
>
> Diff: https://reviews.apache.org/r/62729/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>