[I] Remove emitWarning and add config option to log fallback reasons [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove opened a new issue, #2134:
URL: https://github.com/apache/datafusion-comet/issues/2134

   ### What is the problem the feature request solves?
   
   When Comet falls back to Spark, we tag the operator or expression with the reason using `withInfo`.
   
   Sometimes (but not often) we also emit a warning to stdout.
   
   ```scala
   val msg = s"Unsupported result expressions found in: ${resultExpressions}"
   emitWarning(msg)
   withInfo(op, msg, resultExpressions: _*)
   ```
   
   I would like to propose that we remove the `emitWarning` method and instead add a new config option that would enable logging inside of `withInfo` so that fallback reasons can be logged to stoud.
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Remove emitWarning and add config option to log fallback reasons [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove closed issue #2134: Remove emitWarning and add config option to log fallback reasons
URL: https://github.com/apache/datafusion-comet/issues/2134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org