You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/12/15 12:35:20 UTC

[I] [FEATURE] Support get SQL keywords from Spark engine through API [kyuubi]

pan3793 opened a new issue, #5860:
URL: https://github.com/apache/kyuubi/issues/5860

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the feature
   
   SPARK-43119(Spark 3.5.0) added a `SQLKeywordUtils.keywords` to preserve all SQL keywords, and return such value through `GetInfo#CLI_ODBC_KEYWORDS`, we can do similar things at the Kyuubi side.
   
   ### Motivation
   
   _No response_
   
   ### Describe the solution
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [I] [FEATURE] Support get SQL keywords from Spark engine through API [kyuubi]

Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on issue #5860:
URL: https://github.com/apache/kyuubi/issues/5860#issuecomment-1868748266

   Hi @iodone , I found a newer commit that provided the API, but I didn't track its previous status, FYI: https://github.com/trinodb/trino/blob/master/core/trino-grammar/src/main/java/io/trino/grammar/sql/SqlKeywords.java#L31


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [I] [FEATURE] Support get SQL keywords from Spark engine through API [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #5860:
URL: https://github.com/apache/kyuubi/issues/5860#issuecomment-1857818893

   This ticket is for Spark, can we achieve a similar functionality in other engines? cc @YesOrNo828 @iodone @Yikf 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [I] [FEATURE] Support get SQL keywords from Spark engine through API [kyuubi]

Posted by "iodone (via GitHub)" <gi...@apache.org>.
iodone commented on issue #5860:
URL: https://github.com/apache/kyuubi/issues/5860#issuecomment-1868781452

   It appears that the `trino-cli` has used this API, rather than the sql keyword information provided by the trino server.
   
   
   > Hi @iodone , I found a newer commit that provided the API, but I didn't track its previous status, FYI: https://github.com/trinodb/trino/blob/master/core/trino-grammar/src/main/java/io/trino/grammar/sql/SqlKeywords.java#L31
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [I] [FEATURE] Support get SQL keywords from Spark engine through API [kyuubi]

Posted by "iodone (via GitHub)" <gi...@apache.org>.
iodone commented on issue #5860:
URL: https://github.com/apache/kyuubi/issues/5860#issuecomment-1868669538

   The Trino engine currently does not support an API for keyword retrieval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [I] [TASK][EASY] Support get SQL keywords from Spark engine through API [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed issue #5860: [TASK][EASY] Support get SQL keywords from Spark engine through API
URL: https://github.com/apache/kyuubi/issues/5860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org