You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/28 16:29:50 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
dongjoon-hyun opened a new pull request #32697:
URL: https://github.com/apache/spark/pull/32697
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851066118
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43606/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850909845
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851065745
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850913208
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851066118
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43606/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850909840
**[Test build #139082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139082/testReport)** for PR 32697 at commit [`0921ed2`](https://github.com/apache/spark/commit/0921ed2b7a9f45ff274e03d848c8ceb0a1fca7c6).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851059124
Now, genjavadoc is ready.
- https://github.com/lightbend/genjavadoc/issues/282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851237605
Sure, I agree with you that we need to remove it in Apache Spark 3.2.0 timeframe. Thanks, @iemejia .
> My suggestion to remove silencer was to unblock the issue but this can be definitely be done afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850540197
**[Test build #139065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139065/testReport)** for PR 32697 at commit [`274de13`](https://github.com/apache/spark/commit/274de13595b36f9022ce9da822af8975fe013884).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850909546
**[Test build #139082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139082/testReport)** for PR 32697 at commit [`0921ed2`](https://github.com/apache/spark/commit/0921ed2b7a9f45ff274e03d848c8ceb0a1fca7c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850906811
Hi, @srowen and @iemejia . Yes, it does.
As I wrote in the PR description, I made a PR to **silencer** and it's merged three hours ago and released.
> silencer library is not released yet. ghik/silencer#66
This is the released one.
- https://repo1.maven.org/maven2/com/github/ghik/silencer-plugin_2.12.14/1.7.5/
I'll rebase this PR to the branch to retrigger it. However, the second item, `genjavadoc` is still not ready as I mentioned also.
> genjavadoc library is not released yet. https://repo1.maven.org/maven2/com/typesafe/genjavadoc/
And, @iemejia . I'm intentionally not going down that path. :) We can do that separately after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850906811
Hi, @srowen and @iemejia . Yes, it does.
As I wrote in the PR description, I made a PR to **silencer** and it's merged three hours ago and released.
> silencer library is not released yet. ghik/silencer#66
I'll rebase this PR to the branch to retrigger it. However, the second item, `genjavadoc` is still not ready as I mentioned also.
> genjavadoc library is not released yet. https://repo1.maven.org/maven2/com/typesafe/genjavadoc/
And, @iemejia . I'm intentionally not going down that path. :) We can do that separately after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851059707
**[Test build #139085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139085/testReport)** for PR 32697 at commit [`493b8be`](https://github.com/apache/spark/commit/493b8be6002a47410041d7be84096a8aa48aa75e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32697:
URL: https://github.com/apache/spark/pull/32697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850540197
**[Test build #139065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139065/testReport)** for PR 32697 at commit [`274de13`](https://github.com/apache/spark/commit/274de13595b36f9022ce9da822af8975fe013884).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851075310
Thank you, @srowen , @iemejia , @viirya .
- GitHub Action passed
- Jenkins Scala/Java passed and currently SparkR test is running.
I'll merge this PR for Apache Spark 3.2.0.
BTW, cc @Ngone51 since he reported the cyclic dependency issue last time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851075310
Thank you, @srowen , @iemejia , @viirya .
- GitHub Action passed
- Jenkins Scala/Java passed and currently SparkR test is running.
I'll merge this PR for Apache Spark 3.2.0.
BTW, cc @Ngone51 since he reported the cyclic dependency issue last time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850909546
**[Test build #139082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139082/testReport)** for PR 32697 at commit [`0921ed2`](https://github.com/apache/spark/commit/0921ed2b7a9f45ff274e03d848c8ceb0a1fca7c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850540348
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851076229
**[Test build #139085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139085/testReport)** for PR 32697 at commit [`493b8be`](https://github.com/apache/spark/commit/493b8be6002a47410041d7be84096a8aa48aa75e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zzcclp commented on a change in pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #32697:
URL: https://github.com/apache/spark/pull/32697#discussion_r642178486
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
<commons.math3.version>3.4.1</commons.math3.version>
<!-- managed up from 3.2.1 for SPARK-11652 -->
<commons.collections.version>3.2.2</commons.collections.version>
- <scala.version>2.12.10</scala.version>
+ <scala.version>2.12.14</scala.version>
Review comment:
@dongjoon-hyun please modify the scala version to 2.12.14 in profile `scala-2.12`, otherwise there maybe a `Error:scala: bad option: -P:silencer:globalFilters=.*deprecated.*` error when tick the profile `scala-2.12`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850540348
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851081113
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139085/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iemejia commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851235328
Excellent @dongjoon-hyun! My suggestion to remove silencer was to unblock the issue but this can be definitely be done afterwards.
Great to see the new version of Scala just for the support for more recent JVMs available, hopefully this will win us time to be ready when JVM 17 is released!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850541948
**[Test build #139065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139065/testReport)** for PR 32697 at commit [`274de13`](https://github.com/apache/spark/commit/274de13595b36f9022ce9da822af8975fe013884).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851059707
**[Test build #139085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139085/testReport)** for PR 32697 at commit [`493b8be`](https://github.com/apache/spark/commit/493b8be6002a47410041d7be84096a8aa48aa75e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32697:
URL: https://github.com/apache/spark/pull/32697#discussion_r642190770
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
<commons.math3.version>3.4.1</commons.math3.version>
<!-- managed up from 3.2.1 for SPARK-11652 -->
<commons.collections.version>3.2.2</commons.collections.version>
- <scala.version>2.12.10</scala.version>
+ <scala.version>2.12.14</scala.version>
Review comment:
Oh, thanks. I missed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850909845
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850914818
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850906811
Hi, @srowen and @iemejia . Yes, it does.
As I wrote in the PR description, I made a PR to **silencer** and it's merged three hours ago and released.
> silencer library is not released yet. ghik/silencer#66
This is the released one.
- https://repo1.maven.org/maven2/com/github/ghik/silencer-plugin_2.12.14/1.7.5/
I'll rebase this PR to the branch to retrigger it. However, the second item in the PR description, `genjavadoc` is still not ready as I mentioned also.
> genjavadoc library is not released yet. https://repo1.maven.org/maven2/com/typesafe/genjavadoc/
And, @iemejia . I'm intentionally not going down that path. :) We can do that separately after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851064024
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43606/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-851081113
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139085/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850839936
Looks good if it passes, but looks like some library is missing:
sbt.librarymanagement.ResolveException: Error downloading com.github.ghik:silencer-lib_2.12.14:1.7.5
[error] Not found
[error] Not found
[error] not found: https://maven-central.storage-download.googleapis.com/maven2/com/github/ghik/silencer-lib_2.12.14/1.7.5/silencer-lib_2.12.14-1.7.5.pom
[error] not found: https://repo1.maven.org/maven2/com/github/ghik/silencer-lib_2.12.14/1.7.5/silencer-lib_2.12.14-1.7.5.pom
[error] not found: /home/jenkins/sparkivy/per-executor-caches/2/.m2/repository/com/github/ghik/silencer-lib_2.12.14/1.7.5/silencer-lib_2.12.14-1.7.5.pom
[error] not found: /home/jenkins/sparkivy/per-executor-caches/2/.ivy2/localcom.github.ghik/silencer-lib_2.12.14/1.7.5/ivys/ivy.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850541970
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139065/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850540334
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iemejia commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850873455
From https://github.com/ghik/silencer:
**NOTE**: Scala 2.13.2 and 2.12.13 introduced [configurable warnings](https://github.com/scala/scala/pull/8373).
This means that unless you're still cross compiling for Scala 2.11, this plugin is obsolete, and you should use
[`@nowarn`](https://www.scala-lang.org/api/current/scala/annotation/nowarn.html).
Maybe we can remove it and avoid this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850541970
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139065/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850914818
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #32697: [SPARK-31168][BUILD] Upgrade Scala to 2.12.14
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #32697:
URL: https://github.com/apache/spark/pull/32697#issuecomment-850886994
I see, just exclude it? possibly. Looks like it may just need some time to get cross-published as the artifact appears quite specific to the scala version: https://search.maven.org/search?q=silencer-lib
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org